Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp1002460imd; Thu, 1 Nov 2018 08:48:07 -0700 (PDT) X-Google-Smtp-Source: AJdET5ej4ZVe/LNWwUaVxAEWZMF12jG1I+PlrC4VGRXotNcOwD54kwcHM3B/alTyxqG4q5EF0sms X-Received: by 2002:a62:6dc3:: with SMTP id i186-v6mr8326759pfc.218.1541087287113; Thu, 01 Nov 2018 08:48:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541087287; cv=none; d=google.com; s=arc-20160816; b=bYmKVQ5WDY0Q/LCpOwRwSTFJi8/R7TRNmAz4DL9L+V2Ae8aVo9liiMHw0I4eI8fJYk 2uGxieZ2INNfeFkaKrxgXi8RYdfOi6cHYegSC02o/rx7zRC9IeyZKe/iJmgN/oxI8SBy vWzFN6cHvi0spXVmXtnuWiGHu9qiENrAdAwLVoUSZrMHMt/rZtVVFbnVUDVYUdmbrLu+ jRl37N2PDoZvAS/sRmwzCnAj31muRk0UCoA7aRPhuIrXwuC/AI7e3Nq+MHplI0n08rNb V2Viiz+bUb6jUb501bsCYPRUhvuRfdk+OYPGuv21eBqWF9UQWAg6CiJ6bpEq3C4D1iIu NVsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=G/Wwvy3qsYIMMpM1Kx6YpJjnB35xqlwkd5ohpi4jBVI=; b=p1McJCfThrOd25h1kuGg0NVYZDTbavomPoOaf9cSmL6npMUqYui0/1cYKn4q8T3EmD DjOh9QHwfY1S3yRsSU3h3XnS74AJqUmatakbHo8uVARprz1HecTgKJF+F/NFUNrxTWDV KBei1kmRDNna9kTIW/ZzFZtvC6DtwCFBvoxrlFz8VGvAedyv78TKDXTJIVm+WMlPT+Mk lGz/WoA2bKlP4UqiZ3bScwmsDhEnT9iAYst8Pn0FIMU9rLpZE8asiIcaKQZ1do60dZUb sApu6aKu0gxXriIN9BTHH75/sg3akjJUWmRMHkKofoFkrnlXB4GCKsEHxGNAzT4bk5o/ gg4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sUx3pgfJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y68-v6si119945pfi.61.2018.11.01.08.47.51; Thu, 01 Nov 2018 08:48:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sUx3pgfJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729021AbeKBAut (ORCPT + 99 others); Thu, 1 Nov 2018 20:50:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:54770 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727950AbeKBAut (ORCPT ); Thu, 1 Nov 2018 20:50:49 -0400 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 43D092064C; Thu, 1 Nov 2018 15:47:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541087238; bh=Wgum0xJ58utTgeg4nreWxtxPMg+pgn5vLCPyUZYLPmA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sUx3pgfJXhhLGiLQwPFxoQlzo29j3q5ADKeu6sZ862pcAc9nm4Q0eLO71B/rNyd4b VUeMiqEcZA4doR5JtQ/p2clXDQS7prFZaEPVYTYzQm1aLukziZuE701bx/1WBJet3Q GYtzm02fmcOkl/T7CGRUtYquRzUR40VYvT+Ne9bo= Date: Thu, 1 Nov 2018 11:47:17 -0400 From: Sasha Levin To: Prarit Bhargava Cc: stable@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , Stafford Horne Subject: Re: [PATCH AUTOSEL 4.19 022/146] cpupower: Fix coredump on VMWare Message-ID: <20181101154717.GZ194472@sasha-vm> References: <20181031230541.28822-1-sashal@kernel.org> <20181031230541.28822-22-sashal@kernel.org> <7c08983b-a8c5-0dbc-c8aa-2c6a6799e1ee@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <7c08983b-a8c5-0dbc-c8aa-2c6a6799e1ee@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 01, 2018 at 07:43:35AM -0400, Prarit Bhargava wrote: > > >On 10/31/2018 07:03 PM, Sasha Levin wrote: >> From: Prarit Bhargava >> >> [ Upstream commit f69ffc5d3db8f1f03fd6d1df5930f9a1fbd787b6 ] >> >> cpupower crashes on VMWare guests. The guests have the AMD PStateDef MSR >> (0xC0010064 + state number) set to zero. As a result fid and did are zero >> and the crash occurs because of a divide by zero (cof = fid/did). This >> can be prevented by checking the enable bit in the PStateDef MSR before >> calculating cof. By doing this the value of pstate[i] remains zero and >> the value can be tested before displaying the active Pstates. >> >> Check the enable bit in the PstateDef register for all supported families >> and only print out enabled Pstates. >> > >Hi Sasha, > >This patch, f69ffc5d3db8, depends on 8c22e2f69592 ("cpupower: Fix AMD Family >0x17 msr_pstate size"). Without 8c22e2f69592 the patch below will always read a >value of "0" and not output the correct data. > >8c22e2f69592 must be applied to any stable branch that f69ffc5d3db8 is applied to. I'll grab it too, thank you. -- Thanks, Sasha