Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 1 Nov 2018 16:28:56 +0100 (CET)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Peng Hao <penghao122@sina.com.cn>
cc:     rkrcmar@redhat.com, pbonzini@redhat.com, x86@kernel.org,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Peng Hao <peng.hao2@zte.com.cn>
Subject: Re: [PATCH v2] x86/kvmclock : convert to SPDX identifiers
In-Reply-To: <1541084421-4797-1-git-send-email-penghao122@sina.com.cn>
Message-ID: <alpine.DEB.2.21.1811011623040.1642@nanos.tec.linutronix.de>
References: <1541084421-4797-1-git-send-email-penghao122@sina.com.cn>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Peng,

On Thu, 1 Nov 2018, Peng Hao wrote:

> This patch updates license to use SPDX-License-Identifier
> instead of verbose license text

Again:

 git grep 'This patch' Documentation/process/

This leads you to:

 "Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
  instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
  to do frotz", as if you are giving orders to the codebase to change
  its behaviour."

Documentation is there for a reason.

IOW, writing 'This patch does ....' is not the proper way for writing a
changelog. It's entirely clear that this is a patch. No need to mention
it. Imperative mood means something like this:

Replace the verbose license text with the matching SPDX license identifier.

Thanks,

	tglx