Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp1079851imd; Thu, 1 Nov 2018 09:55:18 -0700 (PDT) X-Google-Smtp-Source: AJdET5dKhKEwiFrMW22Kz2xyBB30K2gp4gRq46DQUoJHHjSGHLYmaVGaDcFtffszLmZtkL6dJ8Wt X-Received: by 2002:a63:db48:: with SMTP id x8mr7562771pgi.365.1541091318719; Thu, 01 Nov 2018 09:55:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541091318; cv=none; d=google.com; s=arc-20160816; b=FAtfqkKKFvSzIIA8hC1LGER/XKTTspA7o5amIiWfrC/HOtENCBh5eVYgRGVb9JBaDo aqehz323xaWbddvhQHnXLAT6mRz5beEBDsGmT3Nu7ixjIJNu87SQ0kCt0+ipCaz/bCop sSuchJx0BimrTE+ailf1mVXPO0fYuXknCfklPQ8kcEtTf0XBjJt6LI86P6e/qc7n8zLA AaxxINqPudGy/2mIjLHRlPrHYxjRkSGRxDS29DcrTQeehcmrlybihnUVE890V1qIJTFU nPSqgE0VGyw/12nJX4dcStDa/urte+XGc3rzhMTFEnH56BXRk5OPirzlVB5Qon6m5ayY kuKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=C1OJkFUK0Px5o2OAWm79FhBuhFJ7D31olmNSiCtJuj8=; b=xiBLCHjU8KgwVXA42HZA4nWO8Qsge9ixGXrkfq1+q2JNB7qGObAQ0jG63Ij+SDrxxJ 4tqEqbylp3ub0ujYRtQn45vv1qSKR1d1Ce2w0SedBl3073M39C/s/tJeQWtqZyjj3Zqd 6JZJW/VAokXxHGQadVwa4PY4ekDNDWb/3DZdRCxXib7uqv8xLeIzHNY5KdSH1kDvW09j YL2m9G6JdBjS5xXECWz693mRb/RjZbcReOMB2kjB1EslQxRCo7z1CSSHfVOZ/GejDIEZ KQsZ7XDKj93/WNdRxo2ErZ3O3VN++IlZ0yO+7NCSZSrAwE1F14NiAWS46ya5ABx0Artf 6qhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=VCbFfad1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v6-v6si29481897plo.134.2018.11.01.09.55.03; Thu, 01 Nov 2018 09:55:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=VCbFfad1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727629AbeKBB4S (ORCPT + 99 others); Thu, 1 Nov 2018 21:56:18 -0400 Received: from merlin.infradead.org ([205.233.59.134]:54646 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727256AbeKBB4S (ORCPT ); Thu, 1 Nov 2018 21:56:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=C1OJkFUK0Px5o2OAWm79FhBuhFJ7D31olmNSiCtJuj8=; b=VCbFfad12xfBvwF8B68hXH9Qm qy5bL40Cw77yHyBkG2t83Z/7GohsMPylqOivhdvUq6eCCQ9ZqNnqr8bMtbV9gvVSu3NTwaWOjfR6F DNO3iRYxVAhofamQ6LuYtN7xrVT/HjRIdrWxVOY/t5O2T6JCP/qLx/BmImYqv8aDvCSHQfURv+k5r dkYphh767jNQ5eW6p8D2Ewfcui5NuMv9gC45rFY1UTnVyHSdFovEj1BCzIDmDbFHtJ51VvuPiwy4O IXjJmU0LMe8Hq6VHtsJcOd/Sa0+fTpFNOHI6wQoM4yZGxbdONa9v5f38Kwy+IcNCjNwbNxpB8T/F2 TUZrgTCdg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gIGCr-0005aW-H7; Thu, 01 Nov 2018 16:52:30 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 2475B2029F9FF; Thu, 1 Nov 2018 17:52:27 +0100 (CET) Date: Thu, 1 Nov 2018 17:52:27 +0100 From: Peter Zijlstra To: Muchun Song Cc: mingo@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] sched/core: Introduce set_next_task() helper for better code readability Message-ID: <20181101165227.GF3178@hirez.programming.kicks-ass.net> References: <20181101164222.43015-1-smuchun@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181101164222.43015-1-smuchun@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org What if anything is the difference with v1 (which I found yesterday and have pending testing).