Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp1512707imd; Thu, 1 Nov 2018 17:28:23 -0700 (PDT) X-Google-Smtp-Source: AJdET5cWwEIkmXA6ILCb46gnDI6dCadZ+i53eLVgw5gCw9SVgWiZE5K3Zi6TXuDpJ247bQX4nvgg X-Received: by 2002:a17:902:9896:: with SMTP id s22-v6mr9451665plp.113.1541118503724; Thu, 01 Nov 2018 17:28:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541118503; cv=none; d=google.com; s=arc-20160816; b=pVimMcDevCt/PDlMMVkrg+XBztTwCG+Ocy7iGtqX6hOg9Hc6eivYUAKAKSr5a5Jpby isZVmG8n7A6BWs+jeP5f8/6Oe/xWQVLCZsu/1NbPWPOPEv5RucJFfQJEGJv0sbracJcl j8gu742q3i8FfSA+rDtOPaafoVZsW3rbzTpbXUDh/tzgGk0pJY5eAvbH/ks5nFY+4j/8 A12PCDQfC09VOuKT8h4Xv+ncmPIsZu0kJ0um/xaQjO94Rtuj8yk9jca9mNw09zGD02wF JG69v8T7aCERseYP/2RqWBm+hRhAmOhUrw0KoSPlxKJuUrCRmlQ8oDgpzao8lXIRe+Ym pTNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=5Yqc2DE/Vr6hLYt2nXt1XTb+plskyFIXNXSMSKpGnsI=; b=T2hIZ4fzIzaKXUtugub/ui7xAHSk21DV5JqyeTErf4f3PXCHS/zndw4uO/6N9PpAuU e/iy9JI2rnkOkCs8wAdKyx+0QIlK6NdnqY4aOcMyjgoomcBUu6X16TM3i8vhp8GCltIx WyfU7Ia1wkGMxVjUrfIZft9Hgnx1bUWGYE6Eg6vbf0Js6irwdsGEf/M+DALgk2VeXH2h T41pe8V6PGJPb1wFlg9jGVsruoK5IX53ON7owDiQU6Wn919U+jfovg/p3KqmZVg6Waoe 0194ATDPhZKDuMeK7+BFf3C4YqwQhaUCXUYoH3fbgM9koFdowgLFUMhNulNpGnJceuUw 3rQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ANGRrndC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a66-v6si25341902pfb.22.2018.11.01.17.28.08; Thu, 01 Nov 2018 17:28:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=ANGRrndC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728343AbeKBJc5 (ORCPT + 99 others); Fri, 2 Nov 2018 05:32:57 -0400 Received: from mail-qk1-f175.google.com ([209.85.222.175]:46647 "EHLO mail-qk1-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728109AbeKBJc5 (ORCPT ); Fri, 2 Nov 2018 05:32:57 -0400 Received: by mail-qk1-f175.google.com with SMTP id q1so435860qkf.13 for ; Thu, 01 Nov 2018 17:27:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=5Yqc2DE/Vr6hLYt2nXt1XTb+plskyFIXNXSMSKpGnsI=; b=ANGRrndCThLyfPrfrGI4PdeaO6rh3Cxa8rNwfCZeENJDTHVJg4MzPi4peF2Uh9SwYo KOpo2dGy31UCON8hajnitM688R267qTn/RKbWrFH+XsHvCSwhNxoTu0aJdJAwb2rfKbo lJ+w8zQiARWKkPVLrNxKUWHez7TQMmiZInr6nY4W6HIsGfhMzwu6QWO5lKyRyg/r8CfJ rlb2dKCyWKU1m8hJoWFtXgd8PYI/3hYsewTzbfEdlqB1nQEPmtXo4OnL5lScPB5eVj8n y9UXli4XxtudsTvu3szD9mUw7rUekbvDw81Cu1YzVHC7Vy4a201V0hexIYaOlVsfUsR/ gNeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=5Yqc2DE/Vr6hLYt2nXt1XTb+plskyFIXNXSMSKpGnsI=; b=RLYwgAPzYOf+nsJ9A23d0fl2e9/rqg5x4i/uzMuHxsgM0O5EJZCaWC3lJLItHPuJqb +CKVThbIfUCWsOj38p7OEGw3IrrsSXJW5JbfWaau5tbWHzj2iAbDQleKU+PUd86V/Q35 MrrLzjnuumA+NHE5FirwDnDS0PLgwBxbywP6lvgDm1TkGtPa+NkDizXF4YKOJsASl6uj adpzJu/oYR1xQbj/xCzjaeVijJccS51ybbFSGxAiT8VfJ29EJW1WQpRVvfta0VzmfSSU E8ugvqpzcpFnGzSryaRqAjVr4kIHe/wExzfM1XWm98tJHyDlrfnLIEodpUHqv19hb14n mo+w== X-Gm-Message-State: AGRZ1gJnuBE0VIprSym3K0n0dBC5xLgI7jdRiBEbjMn6Xp41Xa2eky0d yZ1sQHHOKrT7hxF7zVqF8Pa40Okg31b9Ipb2HcA= X-Received: by 2002:aed:34a6:: with SMTP id x35-v6mr8265718qtd.93.1541118465470; Thu, 01 Nov 2018 17:27:45 -0700 (PDT) MIME-Version: 1.0 References: <20181101164222.43015-1-smuchun@gmail.com> <20181101165227.GF3178@hirez.programming.kicks-ass.net> In-Reply-To: <20181101165227.GF3178@hirez.programming.kicks-ass.net> From: Muchun Song Date: Fri, 2 Nov 2018 08:27:37 +0800 Message-ID: Subject: Re: [PATCH v2] sched/core: Introduce set_next_task() helper for better code readability To: Peter Zijlstra Cc: Ingo Molnar , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Peter Thanks for your review. Just update commit message. So there is no difference between them on the c= ode. Yours, Muchun Song Peter Zijlstra =E4=BA=8E2018=E5=B9=B411=E6=9C=882=E6= =97=A5=E5=91=A8=E4=BA=94 =E4=B8=8A=E5=8D=8812:52=E5=86=99=E9=81=93=EF=BC=9A > > > > What if anything is the difference with v1 (which I found yesterday and > have pending testing).