Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp2049723imd;
        Fri, 2 Nov 2018 05:17:40 -0700 (PDT)
X-Google-Smtp-Source: AJdET5fe9NSPQBv84+Oi4s7QJcCmMy3yxCM0n4XXAOH8WnC69CQtraqUcXJLk3jWQU/fqJNIq7G6
X-Received: by 2002:a63:2d46:: with SMTP id t67mr11037536pgt.140.1541161060650;
        Fri, 02 Nov 2018 05:17:40 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1541161060; cv=none;
        d=google.com; s=arc-20160816;
        b=GkDS3+Xlw1T+s0jnbPo15mxM1UOI2hmo919rh//MmbJUJanZyFXnMoGK+TQ62U8BcD
         dCQmEfdLHcdrWQq/Dc9Sd2/gnKiG/V4zzV0bvBeLx+4U064s5Wsudk0+jXDPnyA6tbTK
         0rzFtVft/Z3OoOu4Q5rZy5wKUlE9Ad98qcojIhpwYoYe5MVoyT2BDyEv1gDYhE8zzVvK
         gnWD7jnxMXdG1O8dexCzLoJkfhBgHWaYZIBDChaOl1tdHjNBgOXT1kc1CT21jiJK0RAj
         AoIz/CORCMno5X4aHhoqRHd1UiJIjnGzfLAPPVTrnskOI3TZ5lAwcUPovKaF2zDADSHy
         9cjw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:date:subject:user-agent:message-id
         :references:cc:in-reply-to:from:to:content-transfer-encoding
         :mime-version;
        bh=isCBgSRA1Plh7gkIC2QhevoviytxEwVkhszoNOId9o4=;
        b=DuL1DPv4D3trOFbV3lMbWinlBjd5IQiyjSuJXbK9br8l8V/LoaU5nE0ByKuOOPJKwK
         +nTYY0pjUxVdPs7yPqTmMDRM1ipMFOsKsU8FWwvnBoW4cJtWu24NqGpWD9IU++7fCfIS
         dm7UcH89yBHRmZgf0v0YcNr60OtMLWBrzbiitRMz72fW1VZ/tIoXZnWgskoVUE1EIAGk
         kqbZ657obdt+76A/kkfUg6SAp2//kpj3ZmOAwR4YSON4bHLdCffd75B2tPetS9tCLSBl
         m4/HBSTjUEF8GIE6ZQWCGfN1Dj8grw/z02DqbDCsGdsPxWSikSPErs9UGvwTflBzPh3b
         zMYQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id u5-v6si34104331pgm.268.2018.11.02.05.17.25;
        Fri, 02 Nov 2018 05:17:40 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726281AbeKBVXt convert rfc822-to-8bit (ORCPT
        <rfc822;stevepeted@gmail.com> + 99 others);
        Fri, 2 Nov 2018 17:23:49 -0400
Received: from mail.fireflyinternet.com ([109.228.58.192]:51068 "EHLO
        fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
        with ESMTP id S1726026AbeKBVXt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 2 Nov 2018 17:23:49 -0400
X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138;
Received: from localhost (unverified [78.156.65.138]) 
        by fireflyinternet.com (Firefly Internet (M1)) with ESMTP (TLS) id 14327656-1500050 
        for multiple; Fri, 02 Nov 2018 12:16:42 +0000
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
To:     Robert Foss <robert.foss@collabora.com>, airlied@linux.ie,
        dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
        robdclark@gmail.com
From:   Chris Wilson <chris@chris-wilson.co.uk>
In-Reply-To: <20181102121313.23271-1-robert.foss@collabora.com>
Cc:     Robert Foss <robert.foss@collabora.com>
References: <20181102121313.23271-1-robert.foss@collabora.com>
Message-ID: <154116100076.30246.13155169401499183452@skylake-alporthouse-com>
User-Agent: alot/0.6
Subject: Re: [PATCH v2] drm/msm: Move fence put to where failure occurs
Date:   Fri, 02 Nov 2018 12:16:40 +0000
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Quoting Robert Foss (2018-11-02 12:13:13)
> If dma_fence_wait fails to wait for a supplied in-fence in
> msm_ioctl_gem_submit, make sure we release that in-fence.
> 
> Also remove this dma_fence_put() from the 'out' label.
> 
> Signed-off-by: Robert Foss <robert.foss@collabora.com>

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Rob, this probably merits a cc:stable tag -- if the wait was interrupted
by a signal, the fence would be leaked.
-Chris