Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] drm/msm: Move fence put to where failure occurs
To:     Chris Wilson <chris@chris-wilson.co.uk>,
        dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20181102121313.23271-1-robert.foss@collabora.com>
 <154116100076.30246.13155169401499183452@skylake-alporthouse-com>
From:   Robert Foss <robert.foss@collabora.com>
Message-ID: <0e882e0f-07a0-e217-6e88-082a09e87986@collabora.com>
Date:   Fri, 2 Nov 2018 13:30:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <154116100076.30246.13155169401499183452@skylake-alporthouse-com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hey Chris,

On 2018-11-02 13:16, Chris Wilson wrote:
> Quoting Robert Foss (2018-11-02 12:13:13)
>> If dma_fence_wait fails to wait for a supplied in-fence in
>> msm_ioctl_gem_submit, make sure we release that in-fence.
>>
>> Also remove this dma_fence_put() from the 'out' label.
>>
>> Signed-off-by: Robert Foss <robert.foss@collabora.com>
> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Danke!

> 
> Rob, this probably merits a cc:stable tag -- if the wait was interrupted
> by a signal, the fence would be leaked.

Ack, CC-ed the v2 submission.


Rob.