Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp2465714imd; Fri, 2 Nov 2018 11:53:39 -0700 (PDT) X-Google-Smtp-Source: AJdET5fKT6LZS5Uvf333QRSTfGIqxnrekNoSGYGOiC4e9oZ/XKg04ht35yJY36q214rH1eXxG/gl X-Received: by 2002:a63:6906:: with SMTP id e6mr11681562pgc.144.1541184819514; Fri, 02 Nov 2018 11:53:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541184819; cv=none; d=google.com; s=arc-20160816; b=doWx72wahFLAvA+Z0P2jgga5l8WUMbw5XoliwDBHHD6ZvEEv1apBzfUj4RvlPxQSUY RW/CATlJPJ7ugK9i9jHq4F9q2vt2mMC/ncsLUINBf0bakuvvOsEiUVVLF3zQ6kSPJ2DM HLPtPe+C35jJ2bwAPlY2xnJB+9zPpIRQJLpQUq0A3L3WHr+OYqF/30hW9Xg3b1RkoNCB KsqO0RpLpk1r+xooyrKvF9tcqSNFbc1BSFL7Ft56CsP7WO679sc4wqvjyUMeg8dHHTus 9Jyc90YoQH87XsNaeXOuPKaN7eRhczxkK2OAPADflxvGS5Fc9xtM7lmKm8ha7vFY0iEo bneQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=c/128VI+zFwik1Ku3bF9w6eBZdOq9Y1JY1C7Uej83Zc=; b=jupVpLySYZWvU/aDC4E1vYP4TV858VVAKvbOLTkycex3FzbGlngAKoG8LfLGvYhCC5 CMI8bpSzd34de0M4vK/jMB0RPMV2VBrwIJ9iA7JopB/979pUDcvxPd/XFllbI2OSh7IK MUho64YVQwTyQP4XuZpEsALAdqcOHEZtEniKR5K9yU5tRURLyAXVYs89P4dUXEQO13YT rosLkKfbzvIkrIQsjZIwsZSLvY+vOirU0wAtvyImBCCbWDtvKza9gE2cU1pyjOjVLeBa a280xV8rGZNyLSsAVMoH+TR+oUcYBSwLr1MqDzkxtQv3lC9McFCrbMXbdSpt3phePP3c gNbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=e9SZmpik; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d24-v6si489130plr.127.2018.11.02.11.53.24; Fri, 02 Nov 2018 11:53:39 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=e9SZmpik; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731046AbeKCEBN (ORCPT + 99 others); Sat, 3 Nov 2018 00:01:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:57138 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726081AbeKCEBM (ORCPT ); Sat, 3 Nov 2018 00:01:12 -0400 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AE45720848; Fri, 2 Nov 2018 18:52:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1541184777; bh=dHqnZbBQBSQyU6Y6L47eCyNrArKuh1gk3R7IUFxbfWA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e9SZmpikcXW2gqKd/wBB8neYf3j0ZDLQ2yxK5T6L4z5n/W+h+1fo+KMz1HvB9RRGc /Omu3FTX7YfEOgmLfP4VAHFy2V5/Rx4RTEWTGZ7IfMotP8FbItkA/ZDyosLjCSf/oP SnRHHh4+gQ2GpaHXXgwaAWvOuSOm3EI0/mjgsuB8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Daniel Mack , Ulf Hansson , Kalle Valo , Sasha Levin Subject: [PATCH 4.14 094/143] libertas: call into generic suspend code before turning off power Date: Fri, 2 Nov 2018 19:34:39 +0100 Message-Id: <20181102182905.418262734@linuxfoundation.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181102182857.064326086@linuxfoundation.org> References: <20181102182857.064326086@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 4f666675cdff0b986195413215eb062b7da6586f ] When powering down a SDIO connected card during suspend, make sure to call into the generic lbs_suspend() function before pulling the plug. This will make sure the card is successfully deregistered from the system to avoid communication to the card starving out. Fixes: 7444a8092906 ("libertas: fix suspend and resume for SDIO connected cards") Signed-off-by: Daniel Mack Reviewed-by: Ulf Hansson Acked-by: Kalle Valo Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/net/wireless/marvell/libertas/if_sdio.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/wireless/marvell/libertas/if_sdio.c b/drivers/net/wireless/marvell/libertas/if_sdio.c index 43743c26c071..39bf85d0ade0 100644 --- a/drivers/net/wireless/marvell/libertas/if_sdio.c +++ b/drivers/net/wireless/marvell/libertas/if_sdio.c @@ -1317,6 +1317,10 @@ static int if_sdio_suspend(struct device *dev) if (priv->wol_criteria == EHS_REMOVE_WAKEUP) { dev_info(dev, "Suspend without wake params -- powering down card\n"); if (priv->fw_ready) { + ret = lbs_suspend(priv); + if (ret) + return ret; + priv->power_up_on_resume = true; if_sdio_power_off(card); } -- 2.17.1