Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp2494804imd; Fri, 2 Nov 2018 12:24:51 -0700 (PDT) X-Google-Smtp-Source: AJdET5em2gHMvQerz33kAYzUR/N7h4umUAnzckt8AcBE5KT4Do0Atl1TIaaqVqXKTgE9Z5srkIvK X-Received: by 2002:a63:24c2:: with SMTP id k185mr11584977pgk.406.1541186691622; Fri, 02 Nov 2018 12:24:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541186691; cv=none; d=google.com; s=arc-20160816; b=ydR2hiNG0G66AaShUC3wXwt4em7V0mWjkciCXuhcG46ejuMzdtCdWyhhBNnMUrZQ7x atiMV3vRSo2xPhHMRZKV4Um8hBFHnvbQTMH+nX+kK2uyZSVJfTZixjVUZP5CxV4NnW+v b2ozxg9XW70svD2JbxlH4jsmAnNeB7wZASHTh3jI05t7kKHXsc4k/QLvlIZVYFRXjkrT 8Jg+VA/aen8x1ry5BwHibEd82MfXhhgUYmMzHK55F5CrszVf52VpA0lzb6DkN81c6BQ6 IM6+JAj8EQOdILw0InS3gwQLMi7H+NOhKNDlusTYptVaYu9/CwfdypAIVbr87+Kg1GrE pIrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=nqCKuDnccsSoq+Jmww40Hb459RiK+AhXpTrDovE2ALM=; b=cTvelL7P53eWrO8ZQq3KXEyhLdOkshfJSssQ/BbOyzobFjW2uQ0Iq2hZm7AxfZuxwY w17Lg7IVvh1gXPyC66pf7rXMNbp6i8Y1zUDW8lImF/2aDN2AYkzCOYuY5XjLhkZO3P61 TGuolEU392ax+CKLmkQsTlfzUi+A7Zypvw470ONU2yQHAFOm2SFYM28EUlQlB7Blu1lH /Xnlaw4zCDuiWPzS3ugD+4xPV42XVpc6l6qTBuS7dcQtQUa87wzujtCQeGCTgAmbiSUn m8xUAkDK6417JCH4gtrql2Ez23kL3aiYKSEFCIr+KESjfWiWpxuMn3yKmyDcFFjs2I7P otGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z20-v6si34457780pfe.245.2018.11.02.12.24.36; Fri, 02 Nov 2018 12:24:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728293AbeKCEcf (ORCPT + 99 others); Sat, 3 Nov 2018 00:32:35 -0400 Received: from lelv0143.ext.ti.com ([198.47.23.248]:57314 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726550AbeKCEce (ORCPT ); Sat, 3 Nov 2018 00:32:34 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id wA2JO3qD011849; Fri, 2 Nov 2018 14:24:03 -0500 Received: from DFLE109.ent.ti.com (dfle109.ent.ti.com [10.64.6.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id wA2JO32m128026 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 2 Nov 2018 14:24:03 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1466.3; Fri, 2 Nov 2018 14:24:03 -0500 Received: from dlep33.itg.ti.com (157.170.170.75) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1466.3 via Frontend Transport; Fri, 2 Nov 2018 14:24:03 -0500 Received: from a0230074-OptiPlex-7010.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by dlep33.itg.ti.com (8.14.3/8.13.8) with ESMTP id wA2JNfva000522; Fri, 2 Nov 2018 14:24:00 -0500 From: Faiz Abbas To: , , , CC: , , , , , Subject: [PATCH 6/6] can: m_can: Add support for transceiver as phy Date: Sat, 3 Nov 2018 00:56:16 +0530 Message-ID: <20181102192616.28291-7-faiz_abbas@ti.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20181102192616.28291-1-faiz_abbas@ti.com> References: <20181102192616.28291-1-faiz_abbas@ti.com> MIME-Version: 1.0 Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add support for implementing the transceiver device as a phy. Instead of a child node, the max_bitrate information is obtained by getting a phy attribute. Fallback to the legacy API if no phy node is found. Signed-off-by: Faiz Abbas --- drivers/net/can/m_can/m_can.c | 23 ++++++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c index 9b449400376b..ed6d84acea20 100644 --- a/drivers/net/can/m_can/m_can.c +++ b/drivers/net/can/m_can/m_can.c @@ -26,6 +26,7 @@ #include #include #include +#include #include /* napi related */ @@ -1582,6 +1583,7 @@ static int m_can_plat_probe(struct platform_device *pdev) struct device_node *np; u32 mram_config_vals[MRAM_CFG_LEN]; u32 tx_fifo_size; + struct phy *transceiver; np = pdev->dev.of_node; @@ -1671,7 +1673,26 @@ static int m_can_plat_probe(struct platform_device *pdev) devm_can_led_init(dev); - of_can_transceiver(dev); + transceiver = devm_phy_optional_get(&pdev->dev, "can_transceiver"); + if (IS_ERR(transceiver)) { + ret = PTR_ERR(transceiver); + dev_err(&pdev->dev, "Couldn't get phy. err=%d\n", ret); + return ret; + } + + if (!transceiver) { + dev_warn(&pdev->dev, "No transceiver phy. Falling back to legacy API\n"); + of_can_transceiver(dev); + } else { + ret = phy_power_on(transceiver); + if (ret) { + dev_err(&pdev->dev, "phy_power_on err:%d\n", ret); + return ret; + } + priv->can.bitrate_max = phy_get_max_bitrate(transceiver); + if (!priv->can.bitrate_max) + dev_warn(&pdev->dev, "Invalid value for transceiver max bitrate. Ignoring bitrate limit\n"); + } dev_info(&pdev->dev, "%s device registered (irq=%d, version=%d)\n", KBUILD_MODNAME, dev->irq, priv->version); -- 2.18.0