Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 02 Nov 2018 23:31:38 -0700 (PDT)
Message-Id: <20181102.233138.738200505012734856.davem@davemloft.net>
To:     mk.singh@oracle.com
Cc:     netdev@vger.kernel.org, eric.dumazet@gmail.com, mkubecek@suse.cz,
        j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bonding:avoid repeated display of same link status
 change
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20181031105729.7442-1-mk.singh@oracle.com>
References: <20181031105729.7442-1-mk.singh@oracle.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: mk.singh@oracle.com
Date: Wed, 31 Oct 2018 16:27:28 +0530

> -			if (slave->delay) {
> +			if (slave->delay &&
> +			    !atomic64_read(&bond->rtnl_needed)) {
 ...
> +			    !atomic64_read(&bond->rtnl_needed)) {
 ...
> +			atomic64_set(&bond->rtnl_needed, 1);
 ...
> +		atomic64_set(&bond->rtnl_needed, 0);
 ...
> @@ -229,6 +229,7 @@ struct bonding {
>  	struct	 dentry *debug_dir;
>  #endif /* CONFIG_DEBUG_FS */
>  	struct rtnl_link_stats64 bond_stats;
> +	atomic64_t rtnl_needed;

There is nothing "atomic" about a value that is only set and read.

And using a full 64-bit value for something taking on only '0' and
'1' is unnecessary as well.