Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp283597imd; Fri, 2 Nov 2018 23:50:48 -0700 (PDT) X-Google-Smtp-Source: AJdET5dqfSf63XvWolqoy+ICPthESAImH53xTqKVpGCjH3tB8luLmA8n6cni2c7MQdoFADncD9ul X-Received: by 2002:a17:902:9044:: with SMTP id w4-v6mr2820929plz.32.1541227848400; Fri, 02 Nov 2018 23:50:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541227848; cv=none; d=google.com; s=arc-20160816; b=jTUsuvEZ06w5mfbaAoz9jy+D93O1QI/eB3u0vBPyiaZ16QIY7zadUhE1qRrf+sS1wT 0grRjJngk6iuzR51wny/l1IpdyeWUNre7U8y1Zhb45dRBcCIFYEdqWZZJEnd1A91S1oZ jPY1rQQWhantwncpfKQLABXklvoQ66ekmHZIroff0PiA/1sG6vbNJHivGQhuQT+LWYSX Gj3xF/bNwKN2weqonWgBGIfPzokDs3PTisu3HtewNOIbHYhTvbDCAiHMAVP4CaWnsRti IZcqhpp5JIhu2w8Gl/9YuWtFESIMdLpPuCRWM4o//ORhKGG23ijbe2y/Q61G5vNtNPIk Y3mQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=ua0gMoVw/L9dEyeREk4jv1dXq6RJv9xMfkdwtFGF4gE=; b=VkHBIeg13W3Tmq+1EDvrwSgygcp6F761elhyd1jbNeBcgKACO6Hlj4TMd76F68YtWU a/PLy3XvXfyHyr9JuTgbE9owXHFN3hbB2NOixVXXujYHpSlUhwJQiPgjwVN9ELxMBjS3 j9ivAzPIX/yTqiBAv5gDugid5J1SO+faQAx9uq/qZ/cH6eQ+ZkCTStvuhtuPanUJWPhy /ospo0vcsPFtNI8c4lhKPceiX5QNFYM3Hou9rnidJ29pffg49yqEJ6SyJ8S9oC5Tz/kD AlnGgNywdeFoNbK5jTiNcXeZWmfQ/6gXiHNtWQ5C7Ru6oVaVCsEYZl1HY1oNj28Vj2hL MCxg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t19-v6si7210674plj.37.2018.11.02.23.50.32; Fri, 02 Nov 2018 23:50:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727820AbeKCQA3 (ORCPT + 99 others); Sat, 3 Nov 2018 12:00:29 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:46240 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726165AbeKCQA3 (ORCPT ); Sat, 3 Nov 2018 12:00:29 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::cf9]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A33EF14525CDB; Fri, 2 Nov 2018 23:50:11 -0700 (PDT) Date: Fri, 02 Nov 2018 23:50:10 -0700 (PDT) Message-Id: <20181102.235010.2148666995129291039.davem@davemloft.net> To: frieder.schrempf@kontron.de Cc: steve.glendinning@shawell.net, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] usbnet: smsc95xx: disable carrier check while suspending From: David Miller In-Reply-To: <1541022739-24678-1-git-send-email-frieder.schrempf@kontron.de> References: <1541022739-24678-1-git-send-email-frieder.schrempf@kontron.de> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 02 Nov 2018 23:50:11 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frieder Schrempf Date: Wed, 31 Oct 2018 22:52:19 +0100 > We need to make sure, that the carrier check polling is disabled > while suspending. Otherwise we can end up with usbnet_read_cmd() > being issued when only usbnet_read_cmd_nopm() is allowed. If this > happens, read operations lock up. > > Fixes: d69d169493 ("usbnet: smsc95xx: fix link detection for disabled autonegotiation") > Cc: > Signed-off-by: Frieder Schrempf Applied and queued up for -stable.