Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp419180imd; Sat, 3 Nov 2018 03:10:47 -0700 (PDT) X-Google-Smtp-Source: AJdET5et+lVne8X/7HeZ0uPcA0uL9PR2SWbEry0NfS5P4fGJee+5JnKNDzF+gSKvMICUPzXH7lAj X-Received: by 2002:a17:902:6184:: with SMTP id u4-v6mr15042728plj.291.1541239847144; Sat, 03 Nov 2018 03:10:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541239847; cv=none; d=google.com; s=arc-20160816; b=yUT9X5qR/JpTn44OOM1DldjT2YfhAim/yyqH5wFkPL1ZU4sLGtRc1HuwqMdVkPx5ig ESbKZl98vJ4Yz5FLMWMy+OKZdx0XXysP+ozrHusJPUwdzbFqkpTr0gRUIUQKyvapcw9k UF6dq7x5VjafRGrzi1jzasGQZhcDClbcsDcjr0b9SOGIz+ZG8DSbnYvKBLO+EvoZ1uK2 AMYdNXKyokdCquOBeXyS+Q/vFxblsT9PJ8PXpPmuqI7liorraveFBbKMA0nI6yTAsy69 tQT1nJlM/Ngepy+qHkI5nORzyjszQ57idlmj+qnZ+6WCoDHpwLDiR8HmtTYLmVmRTpGw HZIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=tQh0tuZ2hAQEjHoUC9QKXmQksrNiyamIN0Q5qO8zC0c=; b=ANTE9hUQEZ93bUQ35sy3MeR6TjjNrQHU/Sm9mzIvX/5TaL/eQpgMCdTm91y5nFmgzp UJSRqLns4lzXn+yRiOoxx2iikoAaXU7knxjdWGkP3UmS9zl+fGXvP/fszr9nHAwJJ0D1 qgo4N0zZJMh4LSox4czgqbr9vmbSxPhEw3269rZ1WH/bGwnrpcj7zlV2UbGrT2aceTH8 DO9Q9mr8n8VRA1ia55lrrm6um61B+q3WIsiC0e0J7TXmNNNzHN7F9jm73OdqqsY8mN+R kIbJTt+w8t7QB21Tf0hS6lvxIW41NjZNZIfo/ZyRFwMGUxvNMKiZBNsvtWRKv+MqicOk nnZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=m8OxtSqN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i12-v6si29621446pgl.83.2018.11.03.03.10.32; Sat, 03 Nov 2018 03:10:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=m8OxtSqN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728513AbeKCTUd (ORCPT + 99 others); Sat, 3 Nov 2018 15:20:33 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:45792 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727281AbeKCTUd (ORCPT ); Sat, 3 Nov 2018 15:20:33 -0400 Received: by mail-pl1-f193.google.com with SMTP id o19-v6so2120543pll.12 for ; Sat, 03 Nov 2018 03:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tQh0tuZ2hAQEjHoUC9QKXmQksrNiyamIN0Q5qO8zC0c=; b=m8OxtSqNuV73V8tWjYgHpyjiVE/7WW0euNVgtiafVS+UL/gBRFpJztSulsHUqMH6s/ +ir8x8ne92OvGOo78xkxTOgwsqTGjrcz6ueC43QKmkhly2SMHHjXn+nNzKmweQVkug1C aG36zcpFkWEsuzbkk84l0ExrwSXtzvo76wSTk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tQh0tuZ2hAQEjHoUC9QKXmQksrNiyamIN0Q5qO8zC0c=; b=fE1Ugo70ZcgRF0zYKfDBgFV3JYcJj04qE2gMvfVfZ54JpDr+SrhQ0/ALp0+gYg9XvR HbD+nhw9OUzcoOgxiv0LtJkce8dTJ7knmESvaqxMgv4hApzCoLAVUX8jXAV3jgBv0BYZ hRGeRrHXuCwm9lkvVzDVwW9Sc9QdDLtzVD1pCUIxIm7LLT9X9QS19WnO7mMl8fAl/hH9 HmgXg/moarjMojsRDXjfDhipOuYQe/OH1nMh9FgllWtflnsNnsEW0wDkTqJHR0TnAysr 1k84ql5KxPkrV99C+izNbgLdGKJBO8vGdiiH0ywYSo25+Od58n6Q3utIH0paR8P7faed o/tg== X-Gm-Message-State: AGRZ1gIrOczY/7mgfp9LtGIPUx9JMJ1J5t2i/9/ktyHGmUJtJY3meTlI RLS0pH/pONdS5pjiDcyYrtvcDg== X-Received: by 2002:a17:902:a5cc:: with SMTP id t12-v6mr6717272plq.298.1541239784745; Sat, 03 Nov 2018 03:09:44 -0700 (PDT) Received: from localhost.localdomain ([2405:204:6094:3f7a:ed0a:fb74:1220:defe]) by smtp.gmail.com with ESMTPSA id z79-v6sm28466823pfl.33.2018.11.03.03.09.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 03 Nov 2018 03:09:44 -0700 (PDT) From: Jagan Teki To: Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , Rob Herring , Chen-Yu Tsai , Icenowy Zheng , Jernej Skrabec , Vasily Khoruzhick , Thierry Reding , Mark Rutland , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michael Trimarchi , TL Lim , linux-sunxi@googlegroups.com Cc: Jagan Teki Subject: [PATCH 03/10] drm/sun4i: sun6i_mipi_dsi: Setup burst mode timings Date: Sat, 3 Nov 2018 15:38:53 +0530 Message-Id: <20181103100900.30313-4-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20181103100900.30313-1-jagan@amarulasolutions.com> References: <20181103100900.30313-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Burst mode display timings are different from convectional video mode so update the horizontal and vertical timings. Reference code taken from BSP (in drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) dsi_hsa = 0; dsi_hbp = 0; dsi_hact = x*dsi_pixel_bits[format]/8; dsi_hblk = dsi_hact; dsi_hfp = 0; dsi_vblk = 0; Signed-off-by: Jagan Teki --- drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 108 ++++++++++++++----------- 1 file changed, 60 insertions(+), 48 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c index 077b57ec964c..4965b2c71e4c 100644 --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c @@ -479,59 +479,71 @@ static void sun6i_dsi_setup_timings(struct sun6i_dsi *dsi, /* Do all timing calculations up front to allocate buffer space */ - /* - * A sync period is composed of a blanking packet (4 bytes + - * payload + 2 bytes) and a sync event packet (4 bytes). Its - * minimal size is therefore 10 bytes - */ + if (device->mode_flags == MIPI_DSI_MODE_VIDEO_BURST) { + hsa = 0; + hbp = 0; + hblk = mode->hdisplay * Bpp; + hfp = 0; + vblk = 0; + } else { + /* + * A sync period is composed of a blanking packet (4 bytes + + * payload + 2 bytes) and a sync event packet (4 bytes). Its + * minimal size is therefore 10 bytes + */ #define HSA_PACKET_OVERHEAD 10 - hsa = max((unsigned int)HSA_PACKET_OVERHEAD, - (mode->hsync_end - mode->hsync_start) * Bpp - HSA_PACKET_OVERHEAD); - - /* - * The backporch is set using a blanking packet (4 bytes + - * payload + 2 bytes). Its minimal size is therefore 6 bytes - */ + hsa = max((unsigned int)HSA_PACKET_OVERHEAD, + (mode->hsync_end - mode->hsync_start) * Bpp - + HSA_PACKET_OVERHEAD); + + /* + * The backporch is set using a blanking packet (4 bytes + + * payload + 2 bytes). Its minimal size is therefore 6 bytes + */ #define HBP_PACKET_OVERHEAD 6 - hbp = max((unsigned int)HBP_PACKET_OVERHEAD, - (mode->htotal - mode->hsync_end) * Bpp - HBP_PACKET_OVERHEAD); - - /* - * hblk seems to be the line + porches length. - * The blank is set using a blanking packet (4 bytes + 4 bytes + - * payload + 2 bytes). So minimal size is 10 bytes - */ + hbp = max((unsigned int)HBP_PACKET_OVERHEAD, + (mode->htotal - mode->hsync_end) * Bpp - + HBP_PACKET_OVERHEAD); + + /* + * hblk seems to be the line + porches length. + * The blank is set using a blanking packet (4 bytes + 4 bytes + * + payload + 2 bytes). So minimal size is 10 bytes + */ #define HBLK_PACKET_OVERHEAD 10 - hblk_max = (mode->htotal - (mode->hsync_end - mode->hsync_start)) * Bpp; - hblk_max -= HBLK_PACKET_OVERHEAD; - hblk = max_t(unsigned int, HBLK_PACKET_OVERHEAD, hblk_max); - - /* - * The frontporch is set using a blanking packet (4 bytes + - * payload + 2 bytes). Its minimal size is therefore 6 bytes - * - * According to BSP code, extra 10 bytes(which is hblk packet overhead) - * is adding for hfp packet overhead since hfp depends on hblk. - */ + hblk_max = (mode->htotal - + (mode->hsync_end - mode->hsync_start)) * Bpp; + hblk_max -= HBLK_PACKET_OVERHEAD; + hblk = max_t(unsigned int, HBLK_PACKET_OVERHEAD, hblk_max); + + /* + * The frontporch is set using a blanking packet (4 bytes + + * payload + 2 bytes). Its minimal size is therefore 6 bytes + * + * According to BSP code, extra 10 bytes(which is hblk packet + * overhead) is adding for hfp packet overhead since hfp + * depends on hblk. + */ #define HFP_PACKET_OVERHEAD 6 - hfp_pkt_overhead = (HFP_PACKET_OVERHEAD + HBLK_PACKET_OVERHEAD); - hfp = max((unsigned int)hfp_pkt_overhead, - (mode->hsync_start - mode->hdisplay) * Bpp - - hfp_pkt_overhead); - - /* - * The vertical blank is set using a blanking packet (4 bytes + - * payload + 2 bytes). Its minimal size is therefore 6 bytes - */ + hfp_pkt_overhead = (HFP_PACKET_OVERHEAD + HBLK_PACKET_OVERHEAD); + hfp = max((unsigned int)hfp_pkt_overhead, + (mode->hsync_start - mode->hdisplay) * Bpp - + hfp_pkt_overhead); + + /* + * The vertical blank is set using a blanking packet (4 bytes + + * payload + 2 bytes). Its minimal size is therefore 6 bytes + */ #define VBLK_PACKET_OVERHEAD 6 - if (device->lanes == 4) { - int tmp; - - tmp = (mode->htotal * Bpp) * mode->vtotal - - (hblk + VBLK_PACKET_OVERHEAD); - vblk = (device->lanes - tmp % device->lanes); - } else { - vblk = 0; + if (device->lanes == 4) { + int tmp; + + tmp = (mode->htotal * Bpp) * mode->vtotal - + (hblk + VBLK_PACKET_OVERHEAD); + vblk = (device->lanes - tmp % device->lanes); + } else { + vblk = 0; + } } /* How many bytes do we need to send all payloads? */ -- 2.18.0.321.gffc6fa0e3