Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181102212405.5911-1-olof@lixom.net> <20181103153925.ozyb4pqnixu6hw4z@holly.lan>
In-Reply-To: <20181103153925.ozyb4pqnixu6hw4z@holly.lan>
From:   Olof Johansson <olof@lixom.net>
Date:   Sat, 3 Nov 2018 09:54:22 -0700
Message-ID: <CAOesGMjW0Ekbo0HmJak81zytLkSMeZq7=Mk8oTT8eVEED9=gEA@mail.gmail.com>
Subject: Re: [PATCH] kdb: fix strncpy warning
To:     Daniel Thompson <daniel.thompson@linaro.org>
Cc:     Jason Wessel <jason.wessel@windriver.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kgdb-bugreport@lists.sourceforge.net, prarit@redhat.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Nov 3, 2018 at 8:39 AM Daniel Thompson
<daniel.thompson@linaro.org> wrote:
>
> On Fri, Nov 02, 2018 at 02:24:05PM -0700, Olof Johansson wrote:
> > kdb does a strncpy(a, b, strlen(b)+1), which makes no sense. Might as
> > well do a strcpy at this point.
> >
> > Fixes this warning:
> >
> > In function 'strncpy', inlined from 'kallsyms_symbol_next' at kernel/debug/kdb/kdb_support.c:239:4:
> > ./include/linux/string.h:253:9: warning: '__builtin_strncpy' specified bound depends on the length of the source argument [-Wstringop-overflow=]
>
> I think we already have a pending patch for this:
> https://lore.kernel.org/patchwork/patch/989013/
>
> When we looked into this there actually is an unchecked overflow here so
> Prarit's fix adds infrastructure to keep track of the remaining length.

I'm not surprised that there are more bugs.

The above patch was posted a month and a half ago though, why is it
not yet merged? Can we get it in by -rc2, please?


-Olof