Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp932241imd; Sat, 3 Nov 2018 13:29:01 -0700 (PDT) X-Google-Smtp-Source: AJdET5cr6ZtfhAV4SHkY9ZPuqmgIAiwNUT1adasQUU4NLnutoQXKfyDeqpBpsO/4465HrdVTXq8x X-Received: by 2002:a63:e505:: with SMTP id r5-v6mr14904077pgh.170.1541276941179; Sat, 03 Nov 2018 13:29:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541276941; cv=none; d=google.com; s=arc-20160816; b=j5e/zyBa96LXcXrgbUhem1JvFr9BYR1NIeqO2fK7kpJrFqihgboSQL4Brk5GRQpA6s VTH+JkRPtzzM8en76WlZhCFGmhQywdScIWfGic0thrzXld8qxDcZXYFHh95OvqfQS577 s7uWtWCeOEzoYRDVHmP1htuOzZ653OpWsB09WorpKBqr9oz13+VTvJzcWyEqRncVKaC6 uhot52FwjTgrCojyt04am+FlOgOhLNV5v71U5Oi8hHr4mjp0AHQ1s1X9gQtnxeE1OGRr r8DWaTBL6qnNKE3AFxhhnkrg1MQLs5VltiIw9wMQN641DKAAG2Bh/3fxhUXQYA7uSumo 7XqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=qZz+NXc+T0OdqetvdeNj6LwnEs8v2IFDQ+MpGCNc8mg=; b=ts7a37Rj8s/FRQOibuldqsqdzLLt5frvxguYA20LRnfc2OoNP/BYTlerEpPWUkKcGy S01Fl8C8laEGfcHTzrOrmkm2aJNQxEQz8wAo1u+gEKBWeZkEH2O2hzzmWRJCrqAZOe4/ uWosWnQTC02ggzDxYycXCJQ3O7XCPdEssPyYg9loTyr1AmcsKCc5aC+XnCR4BJGYBxCX V3HH2ndEJD3CTtxhsd2UvxGYxEvHvFBfVazeqexDkej9r74+FEM0ZnzW4C8P1r4CIzzM fU08Lt/PH0/HymedSmrasASIFFzHjvya97WXQ0a1NNlKNuy5thIuz+0Fm/b1+DOBd80R HchA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=yB82nUED; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z3-v6si37575799pgh.250.2018.11.03.13.28.42; Sat, 03 Nov 2018 13:29:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=yB82nUED; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727034AbeKDFkb (ORCPT + 99 others); Sun, 4 Nov 2018 01:40:31 -0400 Received: from imap.thunk.org ([74.207.234.97]:33626 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726430AbeKDFkb (ORCPT ); Sun, 4 Nov 2018 01:40:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=qZz+NXc+T0OdqetvdeNj6LwnEs8v2IFDQ+MpGCNc8mg=; b=yB82nUEDLeRySOlHVYyCL/pylZ 70gdX98oBztinmJc6XwYRkqRmvoMR5/Z9JcgqipsuQjZvJiuU3wPhXu7J5J3vca2dIAWr3sCjsFlR Q1gizBHXq3qThAGiKg1DcEPMyc0qVRrSf21see3F0APwVDZzgOwC8atRkb2Rfo4gU+4Q=; Received: from root (helo=callcc.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.89) (envelope-from ) id 1gJ2Wd-00087v-FT; Sat, 03 Nov 2018 20:28:07 +0000 Received: by callcc.thunk.org (Postfix, from userid 15806) id 477927A7A7E; Sat, 3 Nov 2018 16:28:06 -0400 (EDT) Date: Sat, 3 Nov 2018 16:28:06 -0400 From: "Theodore Y. Ts'o" To: Vasily Averin Cc: linux-ext4@vger.kernel.org, Andreas Dilger , linux-kernel@vger.kernel.org, Yongqiang Yang , Yongqiang Yang Subject: Re: [PATCH v2 02/11] ext4 resize: missing brelse() after errors in set_flexbg_block_bitmap() Message-ID: <20181103202806.GF28850@thunk.org> Mail-Followup-To: "Theodore Y. Ts'o" , Vasily Averin , linux-ext4@vger.kernel.org, Andreas Dilger , linux-kernel@vger.kernel.org, Yongqiang Yang , Yongqiang Yang References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 31, 2018 at 12:57:45AM +0300, Vasily Averin wrote: > Fixes 33afdcc5402d ("ext4: add a function which sets up group blocks ...") # 3.3 > > Signed-off-by: Vasily Averin Thanks, applied. I adjusted the patch summary: ext4: add missing brelse() in set_flexbg_block_bitmap()'s error path Also please note that properly Fixes should have a colon, and to add Cc: stable@kernel.org to trailer to make sure they get backported: Fixes: 33afdcc5402d ("ext4: add a function which sets up group blocks ...") Cc: stable@kernel.org # 3.3 - Ted