Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp962897imd; Sat, 3 Nov 2018 14:16:22 -0700 (PDT) X-Google-Smtp-Source: AJdET5fhX1mvdPW6UJ/sfIdPoP7pajSdHZc1fijGLIPyPcOsdZ28z9mAr3UOsmF42Lshc2hdoiGB X-Received: by 2002:a62:7597:: with SMTP id q145-v6mr16539918pfc.254.1541279781962; Sat, 03 Nov 2018 14:16:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1541279781; cv=none; d=google.com; s=arc-20160816; b=VUuPZeGJ8jVZl+SH9Np7giWkLaUpBaLNi+B+arPR0+4Lzte4MIcKGxEt+sEBfYQgN7 v+AHHYlZ3IF4DL6DT4jUbxfDQwrHbtSNnS9mSseUgafgJViijZPwjHjzLoNXVNamM4Fk 4gePYMUK2gI+hDcuAQYTm5xcGct3DsqgLM3dmZd9PwAXF3W+iwhmXOybIUAoJ0+5drbh bRqPVF2UoMKbmaysdIO3SC2BaTD7rH1omTl67dLVtssVWSeAzX8Bb2NdGNHiHdJjlqi8 YL/sDVSm2QYh1hQmJLG8nFoL4Xidd9I0cnTn9TskKCJBleLrZSQxecWJY0L5z7kAVC/D OJMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=3E99FgXWflVUPVI9q1FW1Z0AFZIuFEbLW3W6U9ihmGk=; b=ll7ewhwCA+Ou6g541Oq1ZFyKBnH6HIz5Iho11sRjeHvPee5GI9Wu3M+7/L5yGmNLIk syEmUfpbJYELbOpJ/kkeYYSwb6CLs3o8IQnH9mlH8kByY+O3BBwVEjL0Y9eKmR+66xqG AdPKRWzeATm7owXohwnafaa//nD4wtZTvuXhrgse6vyJnxlsf0Ard52ipmQdNEqfaOtw poOe/pH451Toixr89SDHW9jOVk63m6i39nF6FGc5PZS3O9+h0Gzp+DbQi1yCyySDIS7z 96H/lXxa+lilysjqsDsZ/gnK9R2m+ax61Yp0by9XNA9Ohv/ACtDaaMUxgt9/07BeFCsW ExXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=TPZ5TiAo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o11si4413266pgd.234.2018.11.03.14.16.04; Sat, 03 Nov 2018 14:16:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@thunk.org header.s=ef5046eb header.b=TPZ5TiAo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727157AbeKDG0h (ORCPT + 99 others); Sun, 4 Nov 2018 01:26:37 -0500 Received: from imap.thunk.org ([74.207.234.97]:33686 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726907AbeKDG0h (ORCPT ); Sun, 4 Nov 2018 01:26:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=3E99FgXWflVUPVI9q1FW1Z0AFZIuFEbLW3W6U9ihmGk=; b=TPZ5TiAoU3GovnVztUp2UedMHI SVsaPAcC1H4HicyUfnjUIbimqq0Q1R9t4Z9SHV3bfs5v4D9SYM1tFf5A+GLo74ALvmfr6HaRfXzhH MwShhKrnzOTSznd8/Ph5NJJRPV42KbrxFXbV061igTWk/aOn71fUjyw1raX20gfMvaQQ=; Received: from root (helo=callcc.thunk.org) by imap.thunk.org with local-esmtp (Exim 4.89) (envelope-from ) id 1gJ3FB-0008TN-IN; Sat, 03 Nov 2018 21:14:09 +0000 Received: by callcc.thunk.org (Postfix, from userid 15806) id 5F3777A7A7E; Sat, 3 Nov 2018 17:14:08 -0400 (EDT) Date: Sat, 3 Nov 2018 17:14:08 -0400 From: "Theodore Y. Ts'o" To: Vasily Averin Cc: linux-ext4@vger.kernel.org, Andreas Dilger , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 04/11] ext4 resize: lost brelse() in update_backups() Message-ID: <20181103211408.GH28850@thunk.org> Mail-Followup-To: "Theodore Y. Ts'o" , Vasily Averin , linux-ext4@vger.kernel.org, Andreas Dilger , linux-kernel@vger.kernel.org References: <7120b1a5-fcda-8e31-fc8c-7944b4291b14@virtuozzo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7120b1a5-fcda-8e31-fc8c-7944b4291b14@virtuozzo.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 31, 2018 at 12:58:03AM +0300, Vasily Averin wrote: > bh was not released after error in ext4_journal_get_write_access() > > Fixes ac27a0ec112a ("ext4: initial copy of files from ext3") # 2.6.19 > > Signed-off-by: Vasily Averin Thanks, applied. I fixed up the commit description and Fixes/Cc trailers. - Ted