Message-ID: <3FFAADB9.6030801@stud.feec.vutbr.cz>
Date: Tue, 06 Jan 2004 13:44:41 +0100
From: Michal Schmidt <xschmi00@stud.feec.vutbr.cz>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040104
MIME-Version: 1.0
To: linux-kernel@vger.kernel.org
Subject: Re: 2.6.1-rc1 affected?
References: <1aFW7-39l-11@gated-at.bofh.it> <1aG5G-3mf-21@gated-at.bofh.it>
In-Reply-To: <1aG5G-3mf-21@gated-at.bofh.it>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 857
Lines: 23

Linus Torvalds wrote:
> I'd actually personally prefer a stronger test than the one in 2.4.24, and 
> my personal preference would be for just disallowing the degenerate cases
> entirely.  I don't see a "mremap away" as being a valid thing to do, since 
> if that is what you want, why not just do a "munmap()"?
> 

I belive your fix isn't correct.
Should that test be:
   if(!old_len || !new_len)
        goto out;
?

The difference is when old_len!=0 and new_len==0:
With the fix that Marcelo merged, mremap does nothing and returns -1.
With your fix, mremap does do_munmap and then returns -1.

Michal Schmidt
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/