Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp1845034imd; Sun, 4 Nov 2018 10:40:35 -0800 (PST) X-Google-Smtp-Source: AJdET5f2Pc7Flgg7zwMZM9O04In2Da7ZwDUC2pjHAs5+NIoHt1R0aL2MjTEoTY7xccFCNqH3J0w3 X-Received: by 2002:a63:310:: with SMTP id 16mr17192821pgd.79.1541356835169; Sun, 04 Nov 2018 10:40:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541356835; cv=none; d=google.com; s=arc-20160816; b=Zu3AMMda74VSNHffLw+IHfKQWQ1RhBBiEX05LIrcNuEOYjOxSdSfvxC/gIGjtEnv4H 4Jg5XU3zmkAtrEX7eVDsl+CMD9UZVTr+IPrkbhhjKm9tlr+JVI+KBnDvawsgV1XEtrKQ pXUMbuoZCBKKx3lyrVHJHyyEeLrQ8VBS8eZJN0Exa1Kk+STMmLD40iLlIwWBycQRVW5e /LexBSUv7kzMXceouaNNP1B19mQK1rYAeE4amS5olY2hC3t2uKI3+AmWi3HAUAsvG+yu fiMwJ7/AmNyRKwk0uiSPG0x+4VA24pvay/BbDgQf7ivo2y1m75wNFKYr2oMQtEUqCadS J79g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=l8UcfMMPC1etJE5E51oUIa2EP+LkM+VqvFO09cszmtc=; b=sqQZegBD9mdl9NuS2k6Xu9LYCQyEiZLB8RxOHSulnfBlMDcAghDR5d07rQVfY+eLqH L/ujIQO+D0vbD1h/Ruj6gCQHHXMtD/nqOOlvss9Co3T3JtnJMa+TZ9Db0Y9JxIl8FY1l 3UyWabOCZ5wakCw/U6WdncrABp/T/JL6i2PkyAtm9spthZBDLWsqfBLgG1Zo/NRSQ/CQ Hg6nTK8Gah0obAbjYjYsNyfE3/OKV0ZvtJf9COR4ninxeKDXUCowDJyISiY2990cq5L4 d1Az8IIN52eRD+NEarNG4WA44E/78maSp/8k9/O2xOpitdkaX/Sy1WJ08vwa7/5AmcFY ZGZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="p6o9/8YV"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c4-v6si38385510plo.69.2018.11.04.10.40.20; Sun, 04 Nov 2018 10:40:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="p6o9/8YV"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732023AbeKEB51 (ORCPT + 99 others); Sun, 4 Nov 2018 20:57:27 -0500 Received: from mail-io1-f65.google.com ([209.85.166.65]:37789 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732013AbeKEB51 (ORCPT ); Sun, 4 Nov 2018 20:57:27 -0500 Received: by mail-io1-f65.google.com with SMTP id k17-v6so4790874ioc.4; Sun, 04 Nov 2018 08:41:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=l8UcfMMPC1etJE5E51oUIa2EP+LkM+VqvFO09cszmtc=; b=p6o9/8YV4XfULgwfTehbitEtirSYkgRwzbRcGj20ewwqoKIhHFniZF1HXgzlNdlPTX bwdbO+RmQhl1l126yrMmCCbo9p/vErzUCsiMb+zxAOHUj6sDrqjfBXuQsQZbHFVEprGc A4NaLm4nFWlXbPzlcNZ8Ov/skKdhSPFVKKhT22Q/Dy8fPkGZ4/YHx+S2GLiNRDGkfFBV 945TEKW0F4vEproGEiwSWS0n3EvV/Cfvk9gaaLVp5Mu2O86SMOdowAR8g0cfM2Nhiq+M /EIR8WNaLDe6xtAYSS9o4YmxYpp4OYyeh+5cx30itIbSq0u4+STgdGKUCnDi9ch1cVBw hZfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=l8UcfMMPC1etJE5E51oUIa2EP+LkM+VqvFO09cszmtc=; b=Wq0uHA5ZdGIxpAdSqaYKs1j6MKBU3KN+kY9LUvZYmtvzpB5Fcq+YjvYwAqlskgJcgq h9auUl57zZGua7c2Fj7wKc1vbrUJANHahGdr9Be/mmeh4CPCWaOjcp/F8eIYQkdfAMWL JxAFvp4PntMkAS4rL5lcqWYnOaIVu77d+NLpaitAK9bFDY9B1yeBzVg9S/YVN6HPLyg8 ZIRzg+DqpJEcwf4ocDAQ8INDu0MqsPBlVXN9SqWJy2pXfAbpNcpkFHzJqcSYpX9vcHt8 TEPrD3m0BjUIZvOBXo7XzJwRQI0vXKSP4NG+SSYHDJo7Kjqx/82KTFBfVAwewNImPuQg R21w== X-Gm-Message-State: AGRZ1gI43YECcUPY6YJsuc/KypdJ98cQacfxZ3AEVqeC+R6tDRAsO7cm XJfWQyMXyyoXS937Ep2g+PxaTx7Tijyg8IFt2Zo= X-Received: by 2002:a5e:8217:: with SMTP id l23-v6mr11552995iom.232.1541349713268; Sun, 04 Nov 2018 08:41:53 -0800 (PST) MIME-Version: 1.0 References: <20181027150910.GA2070@syn-yoga530> <20181030205624.GC13681@bhelgaas-glaptop.roam.corp.google.com> In-Reply-To: From: Elie Morisse Date: Sun, 4 Nov 2018 13:41:41 -0300 Message-ID: Subject: Re: [PATCH v7] i2c: Add PCI and platform drivers for the AMD MP2 I2C controller To: Tobias Thomer Cc: helgaas@kernel.org, linux-i2c@vger.kernel.org, Wolfram Sang , Nehal-bakulchandra.Shah@amd.com, Shyam-sundar.S-k@amd.com, sandeep.singh@amd.com, linux-kernel@vger.kernel.org, rjw@rjwysocki.net, lenb@kernel.org, linux-acpi@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The errors on module exit and the hang after a read/write timeout should be fixed in v8, someone else reported the same issue here: https://github.com/Syniurge/i2c-amd-mp2/issues/1 Weird that despite a lot of trying by doing random stuff with my touchpad a= nd touchscreen neither never ever timed out on my Yoga 530. Le mar. 30 oct. 2018 =C3=A0 18:41, Tobias Thomer = a =C3=A9crit : > > I've tested this patch on a Yoga 530 and it seems to work (sometimes for = hours) but it randomly dies with a i2c read timeout > > [ 9562.237020] i2c_amd_plat_mp2 AMDI0011:00: i2c read timed out > > and reloading/removing of the module results in this: > > [ 9703.591021] pcie_mp2_amd 0000:03:00.7: length 0 in event doesn't match= buffer length 64! > [ 9703.591030] pcie_mp2_amd 0000:03:00.7: unexpected slave address 0 (exp= ected: 2c)! > [ 9703.863740] i2c_amd_plat_mp2 AMDI0011:01: i2c connection timed out > [ 9707.596826] INFO: task irq/67-WCOM517E:340 blocked for more than 120 s= econds. > [ 9707.596838] Tainted: G OE 4.19.0-v7 #1 > [ 9707.596841] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disable= s this message. > [ 9707.596845] irq/67-WCOM517E D 0 340 2 0x80000080 > [ 9707.596851] Call Trace: > [ 9707.596868] ? __schedule+0x29b/0x8b0 > [ 9707.596873] schedule+0x32/0x90 > [ 9707.596875] schedule_preempt_disabled+0x14/0x20 > [ 9707.596879] __mutex_lock.isra.0+0x217/0x520 > [ 9707.596884] ? __switch_to_asm+0x40/0x70 > [ 9707.596887] ? __switch_to_asm+0x34/0x70 > [ 9707.596890] ? __switch_to_asm+0x34/0x70 > [ 9707.596898] amd_mp2_read+0x4f/0x17b [i2c_amd_pci_mp2] > [ 9707.596912] i2c_amd_xfer+0x61/0x150 [i2c_amd_plat_mp2] > [ 9707.596919] __i2c_transfer+0x142/0x480 > [ 9707.596922] ? _raw_spin_unlock_irq+0x1d/0x30 > [ 9707.596926] ? irq_forced_thread_fn+0x70/0x70 > [ 9707.596929] i2c_transfer+0x51/0xc0 > [ 9707.596932] i2c_transfer_buffer_flags+0x4c/0x70 > [ 9707.596937] i2c_hid_irq+0x3c/0x130 [i2c_hid] > [ 9707.596941] irq_thread_fn+0x1f/0x50 > [ 9707.596944] irq_thread+0xf7/0x1a0 > [ 9707.596946] ? irq_thread_check_affinity.part.3+0xa0/0xa0 > [ 9707.596949] ? irq_thread_dtor+0xb0/0xb0 > [ 9707.596953] kthread+0x112/0x130 > [ 9707.596956] ? kthread_park+0x80/0x80 > [ 9707.596959] ret_from_fork+0x22/0x40