Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp1888836imd; Sun, 4 Nov 2018 11:46:47 -0800 (PST) X-Google-Smtp-Source: AJdET5cjHKFYfbHxLx8/xH8sx60LOBbQ4OkMo/7XRbjAn4x1npXTi/hEE2uxOO57LVcWP+P/5X3m X-Received: by 2002:a63:cd4a:: with SMTP id a10-v6mr4585607pgj.252.1541360807639; Sun, 04 Nov 2018 11:46:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541360807; cv=none; d=google.com; s=arc-20160816; b=HMPafSjGFnttklBF60R/FOmqYdZ2Z6PsCoNVf0b2uHXCyrZWJGU+mt87CZmXMrt1ke DOfT54kjPhOd/TzWh1Tdes3rFO6yeXJWg7sSKycRpclLb2vsWI8t3tC2oxoatO+v26X5 2Nn5y1YnUAxAyckYNIKm+M7aDZ2IFiTOxgrjHGvGuUPJYNjSoyb8RtpxbgjeqZSPpcde rwBvt2wABqUA/174LdEornnxW/2i46tCSt4/R9v8zX/rhKuVf+jvVyCW3mQVeNLPmIjJ Yj+zzzoZeUL8N25sJihSundnlvxCTnijusmBX3wLGsZIAHY9RunejJkQU6wm/csb8wuE W20Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=NY+OGv/CHR4K4cNocaSRL3GmZ8xDse/cw2O69aG/C64=; b=HKpY5tm6yx0EByGH3R6c+cXYkTjb/8yWwN/QFpP1A76sSEfU6PXYtzb5WFMcNwUaxQ wTZAm8yvcTxA/9fIRDzaXnkQYZjyybZ4GNTRaz59PTn7KpXF40tAmMCtegkAMWj8oBWW 2dfRr2axvqwZzUOW4R5oiQtRfjvfn/rxui12NOTQuMKNqwYDbboL708DdBKu5GgFeY92 uxWZldJOe9J5OKykkwGUSjGcfnA4i2PDi71J+kNxNIa+/1tLNLgrvN3pPP4j1CDD4UWn 8gnlVbIVLDMIftwDFwOQOC18uVWin8tli59AWEtYmxUuoSwfEEbuOh8XhZFagqZ21Di9 slGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u11-v6si41371777plr.122.2018.11.04.11.46.33; Sun, 04 Nov 2018 11:46:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387566AbeKEDnz (ORCPT + 99 others); Sun, 4 Nov 2018 22:43:55 -0500 Received: from mailoutvs27.siol.net ([185.57.226.218]:47353 "EHLO mail.siol.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2387541AbeKEDnz (ORCPT ); Sun, 4 Nov 2018 22:43:55 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 453DF521233; Sun, 4 Nov 2018 19:28:00 +0100 (CET) X-Virus-Scanned: amavisd-new at psrvmta11.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta11.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id CLE2Wv79EP_6; Sun, 4 Nov 2018 19:27:59 +0100 (CET) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id C3E2D521257; Sun, 4 Nov 2018 19:27:59 +0100 (CET) Received: from localhost.localdomain (cpe1-8-82.cable.triera.net [213.161.8.82]) (Authenticated sender: 031275009) by mail.siol.net (Postfix) with ESMTPSA id 3EE63521270; Sun, 4 Nov 2018 19:27:57 +0100 (CET) From: Jernej Skrabec To: maxime.ripard@bootlin.com, wens@csie.org Cc: robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, airlied@linux.ie, architt@codeaurora.org, a.hajda@samsung.com, Laurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-sunxi@googlegroups.com, jernej.skrabec@siol.net Subject: [PATCH v3 11/28] drm/sun4i: Disable unused DE2 sub-engines Date: Sun, 4 Nov 2018 19:26:48 +0100 Message-Id: <20181104182705.18047-12-jernej.skrabec@siol.net> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181104182705.18047-1-jernej.skrabec@siol.net> References: <20181104182705.18047-1-jernej.skrabec@siol.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some sub-engines are unused. Disable them explicitly. Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_mixer.c | 8 ++++++++ drivers/gpu/drm/sun4i/sun8i_mixer.h | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.c b/drivers/gpu/drm/sun4i/= sun8i_mixer.c index 6769ec08c0d3..ec2c264f9481 100644 --- a/drivers/gpu/drm/sun4i/sun8i_mixer.c +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.c @@ -462,6 +462,14 @@ static int sun8i_mixer_bind(struct device *dev, stru= ct device *master, /* Reset the registers */ for (i =3D 0; i < DE2_MIXER_UNIT_SIZE; i +=3D 4) regmap_write(mixer->engine.regs, i, 0); + /* Disable unused sub-engines */ + regmap_write(mixer->engine.regs, SUN8I_MIXER_FCE_EN, 0); + regmap_write(mixer->engine.regs, SUN8I_MIXER_BWS_EN, 0); + regmap_write(mixer->engine.regs, SUN8I_MIXER_LTI_EN, 0); + regmap_write(mixer->engine.regs, SUN8I_MIXER_PEAK_EN, 0); + regmap_write(mixer->engine.regs, SUN8I_MIXER_ASE_EN, 0); + regmap_write(mixer->engine.regs, SUN8I_MIXER_FCC_EN, 0); + regmap_write(mixer->engine.regs, SUN8I_MIXER_DCSC_EN, 0); =20 /* Enable the mixer */ regmap_write(mixer->engine.regs, SUN8I_MIXER_GLOBAL_CTL, diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.h b/drivers/gpu/drm/sun4i/= sun8i_mixer.h index 09e0f4428c1e..a4175b993e0d 100644 --- a/drivers/gpu/drm/sun4i/sun8i_mixer.h +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.h @@ -101,8 +101,8 @@ #define SUN8I_MIXER_FBFMT_YUV411 14 =20 /* - * These sub-engines are still unknown now, the EN registers are here on= ly to - * be used to disable these sub-engines. + * Sub-engines listed bellow are unused for now. The EN registers are he= re only + * to be used to disable these sub-engines. */ #define SUN8I_MIXER_FCE_EN 0xa0000 #define SUN8I_MIXER_BWS_EN 0xa2000 --=20 2.19.1