Received: by 2002:ac0:98c7:0:0:0:0:0 with SMTP id g7-v6csp2085693imd; Sun, 4 Nov 2018 16:52:43 -0800 (PST) X-Google-Smtp-Source: AJdET5dRBhssvYIzpMrKbUwoT+rPsR/OEGFdTD1JUdJ3IhY51tlQE8rOe7tM5piOl8a5pTucX0nB X-Received: by 2002:a62:714a:: with SMTP id m71-v6mr13720786pfc.89.1541379163097; Sun, 04 Nov 2018 16:52:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541379163; cv=none; d=google.com; s=arc-20160816; b=adosl88o8Cm+WtAP97OGnanWrqu/ZCQhAQCLSkK5dMjBraxArxEiY5pNEZ4CcjGAPa XTxtYg4SdZ1+XY+pRVA98aJ3V32F4BohIspZjnH2Od1TldgtrzEpfmQrIfUwyiuuudDC bzAFjbjJeus64x4ExevfrOjXqjCM0EhPUGYIHv0Gu2mGI34shSkr9VZLQ96A+Y4xj/GN 0Kvwddx3oakcrGPfns5YAAUS4xo+jNAFVa9Kk2soeyJHrZzM/9bG0O8N4HY038/Rc9ux powK2l53J2LpHyJyTyRobbaB7sE5ygTXICZpHGlcTDi9cT3YDWCd0Z0bKsuHVfU1s/of bEdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:cc:to :subject:from; bh=3+9nOJfv1Giy/GsTEbrqN61DZ7j3uZOtL7gHu+ElGdU=; b=xUzzjoo10EGzstQET93IOgMTo7Ujv6S7+bYdPc50GXh+lZiVnqXuxIxt/rM6j0GR16 L1dgpX0Yd61xh57ypuy5xv8wCiSs41BSVxdtEnziE2hcnL+AK96FWouVKZF0gnY4zHNQ 27WBfY/dAF1QoW2kgE4LFcYlSsIMrd2DHbLw+YsobtAIwYcQHDMpPBxvjKXDhFeG0NDn 5AUls1ge4NulJJKvP1vdFmmnYa1BqoX4DDFrqADPaqaBHdqYytF7zDdsgjYVuXy+ETnL lv0kW7wIqKI7gYtWzErweasqXBBFaWyb+570a/ZBHVTh1eCt1gABeJNr8yy0kLjRVgLv hHzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d4-v6si25024024pla.203.2018.11.04.16.52.28; Sun, 04 Nov 2018 16:52:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=virtuozzo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730155AbeKEH3k (ORCPT + 99 others); Mon, 5 Nov 2018 02:29:40 -0500 Received: from relay.sw.ru ([185.231.240.75]:54600 "EHLO relay.sw.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729223AbeKEH3j (ORCPT ); Mon, 5 Nov 2018 02:29:39 -0500 Received: from [172.16.24.21] by relay.sw.ru with esmtp (Exim 4.90_1) (envelope-from ) id 1gJQdl-00063N-Gh; Mon, 05 Nov 2018 01:13:05 +0300 From: Vasily Averin Subject: [PATCH 1/2] mm: use kvzalloc for swap_info_struct allocation To: linux-mm@kvack.org, Andrew Morton Cc: Huang Ying , linux-kernel@vger.kernel.org, Aaron Lu Message-ID: <37b60523-d085-71e9-fef9-80b90bfcef18@virtuozzo.com> Date: Mon, 5 Nov 2018 01:13:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org commit a2468cc9bfdf ("swap: choose swap device according to numa node") increased size of swap_info_struct up to 44 Kbytes, now it requires 4th order page. Switch to kvzmalloc allows to avoid unexpected allocation failures. Signed-off-by: Vasily Averin --- mm/swapfile.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mm/swapfile.c b/mm/swapfile.c index 644f746e167a..8688ae65ef58 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -2813,7 +2813,7 @@ static struct swap_info_struct *alloc_swap_info(void) unsigned int type; int i; - p = kzalloc(sizeof(*p), GFP_KERNEL); + p = kvzalloc(sizeof(*p), GFP_KERNEL); if (!p) return ERR_PTR(-ENOMEM); @@ -2824,7 +2824,7 @@ static struct swap_info_struct *alloc_swap_info(void) } if (type >= MAX_SWAPFILES) { spin_unlock(&swap_lock); - kfree(p); + kvfree(p); return ERR_PTR(-EPERM); } if (type >= nr_swapfiles) { @@ -2838,7 +2838,7 @@ static struct swap_info_struct *alloc_swap_info(void) smp_wmb(); nr_swapfiles++; } else { - kfree(p); + kvfree(p); p = swap_info[type]; /* * Do not memset this entry: a racing procfs swap_next() -- 2.17.1