Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/1] vhost: add per-vq worker thread
To:     Vitaly Mayatskikh <v.mayatskih@gmail.com>,
        "Michael S . Tsirkin" <mst@redhat.com>
Cc:     kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20181102160710.3741-1-v.mayatskih@gmail.com>
 <20181102160710.3741-2-v.mayatskih@gmail.com>
From:   Jason Wang <jasowang@redhat.com>
Message-ID: <fe79c7fd-1e9f-dab8-3c65-8151181c922c@redhat.com>
Date:   Mon, 5 Nov 2018 10:53:42 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20181102160710.3741-2-v.mayatskih@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2018/11/3 上午12:07, Vitaly Mayatskikh wrote:
> +
> +static int vhost_vq_poll_start(struct vhost_virtqueue *vq)
> +{
> +	if (!vq->worker) {
> +		vq->worker = kthread_create(vhost_vq_worker, vq, "vhost-%d/%i",
> +					    vq->dev->pid, vq->index);
> +		if (IS_ERR(vq->worker)) {
> +			int ret = PTR_ERR(vq->worker);
> +
> +			pr_err("%s: can't create vq worker: %d\n", __func__,
> +			       ret);
> +			vq->worker = NULL;
> +			return ret;
> +		}
> +	}
> +	vhost_work_init(&vq->work, vhost_vq_poll_start_work);
> +	vhost_vq_work_queue(vq, &vq->work);
> +	return 0;
> +}
> +


I wonder whether or not it's better to allow the device to specific the 
worker here instead of forcing a per vq worker model. Then we can keep 
the behavior of exist implementation and do optimization on top?

Thanks