Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1540570303-6097-1-git-send-email-vincent.guittot@linaro.org>
 <1540570303-6097-3-git-send-email-vincent.guittot@linaro.org>
 <6d0b324e-5e26-a510-9bcd-97f475e515ed@arm.com> <CAKfTPtAPsq3fYrLEX7otQ+6Wy5JrQsYG8nLnEWT+09JBi=iKnQ@mail.gmail.com>
 <145bfbd2-f07f-6312-ca2f-029a5301fb15@arm.com>
In-Reply-To: <145bfbd2-f07f-6312-ca2f-029a5301fb15@arm.com>
From:   Vincent Guittot <vincent.guittot@linaro.org>
Date:   Mon, 5 Nov 2018 08:59:42 +0100
Message-ID: <CAKfTPtDVuOJbovFo+7Xucavom-F7nhGxp=y7YMkQUR3y8fDVGg@mail.gmail.com>
Subject: Re: [PATCH v5 2/2] sched/fair: update scale invariance of PELT
To:     Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc:     Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Morten Rasmussen <Morten.Rasmussen@arm.com>,
        Patrick Bellasi <patrick.bellasi@arm.com>,
        Paul Turner <pjt@google.com>, Ben Segall <bsegall@google.com>,
        Thara Gopinath <thara.gopinath@linaro.org>,
        pkondeti@codeaurora.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 1 Nov 2018 at 10:38, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>
> On 10/31/18 10:18 AM, Vincent Guittot wrote:
> > Hi Dietmar,
> >
> > On Wed, 31 Oct 2018 at 08:20, Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
> >>
> >> On 10/26/18 6:11 PM, Vincent Guittot wrote:
> >>
> >> [...]
> >>
> >>>    static int select_idle_sibling(struct task_struct *p, int prev_cpu, int cpu);
> >>>    static unsigned long task_h_load(struct task_struct *p);
> >>> @@ -764,7 +763,7 @@ void post_init_entity_util_avg(struct sched_entity *se)
> >>>                         * such that the next switched_to_fair() has the
> >>>                         * expected state.
> >>>                         */
> >>> -                     se->avg.last_update_time = cfs_rq_clock_task(cfs_rq);
> >>> +                     se->avg.last_update_time = cfs_rq_clock_pelt(cfs_rq);
> >>>                        return;
> >>>                }
> >>>        }
> >>
> >> There is this 1/cpu scaling of se->avg.util_sum (running_sum) in
> >> update_tg_cfs_runnable() so it can be used to calculate
> >> se->avg.runnable_load_sum (runnable_sum). I guess with your approach
> >> this should be removed.
> >
> > Yes good catch
>
> Another thing, since you do not need the cpu parameter in
> accumulate_sum() anymore, you could also get rid of it in
> ___update_load_sum() and further in __update_load_avg_blocked_se(),
> __update_load_avg_cfs_rq() and __update_load_avg_se().

yes, I have to clean interface from reference to cpu

>
> Nitpick: The function header of update_cfs_rq_load_avg() mentions '@now:
> current time, as per cfs_rq_clock_task()' ... should mention
> cfs_rq_clock_pelt() instead.

ok

>
> [...]