Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp272041imu; Mon, 5 Nov 2018 00:07:49 -0800 (PST) X-Google-Smtp-Source: AJdET5cvtjn0Nga1Xnc9u8yZTVJlGUdhbFRlDOLfC26z/tGGVeoe4Ti+n7yjiys3kwo/2L4zOhWi X-Received: by 2002:a63:2109:: with SMTP id h9mr19324487pgh.277.1541405269608; Mon, 05 Nov 2018 00:07:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541405269; cv=none; d=google.com; s=arc-20160816; b=YzO7DxX9wW3pZu+iFoIgVbksUljIMZYGxgmmLfAqtKxXdamJW8F9prU0BSynMSaae3 0Slzq0L4ZY0HLK8mgVdfRdFY3TdI9aSryNwjwuaE2WvV3KgXt7ctINCEFQBBCnyjKmqY esOzuDZKmf71kB8/eO8V+OGpoT679lJKOhhWEMy9rQ4N9acPj1PtXJ/mKtLLXatmBpSh RTYBsyW37L06jEDoKo5QmMmUU2gYveXVG7W5zXSiJuEZtZPEJ5GbM4GakxmPyTUOvhzt CNK1ZUL5p7TcMoG9rKxnmpQf4U2lfC1yQV8mTa9jH1yMBA3jO79yfNiSIU7WCF0GZ8bR rNtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=cq1JxRAhNbOBWaX6T+S0L1OjumNpUCOs4dqvgCoLCGs=; b=xO/27AskZXhWCCouclpGoKNL9h6MtEQl+AXM+TWO15H/HpFBwEARreqYI8Zbswg/QI ZOCxL4zJ1d3BR2aB0U1WXUpuCrmLFRsUZcDbbFE37iCOM3m/WkjFFexBMMOOvuwoIW3M J9NRGnxA5JGkAEm6zGlegsLwDFln/Eq4ASOENEtFR3iSBtm71FL5UrNas+cKu935Mz8/ +sq2gJwKpJkvp5r4vSpd81Q7VzBSfKTJCHBBIrDmWjZV1bBFNeSzi0hsWqHRk53Shrim oJlAJ/dR88/e6V6T6Zq1K8Xeyr8aNZU3Ddi6Yeg1ZSn0zDolPnuMhjadwYnAPVEcDFQr KAYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=lqrHoQ6V; dkim=pass header.i=@codeaurora.org header.s=default header.b=YckzqTUg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b2-v6si45054180plk.356.2018.11.05.00.07.33; Mon, 05 Nov 2018 00:07:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=lqrHoQ6V; dkim=pass header.i=@codeaurora.org header.s=default header.b=YckzqTUg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726474AbeKERZj (ORCPT + 99 others); Mon, 5 Nov 2018 12:25:39 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:43874 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725737AbeKERZj (ORCPT ); Mon, 5 Nov 2018 12:25:39 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 34B636077A; Mon, 5 Nov 2018 08:07:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1541405231; bh=Zy48dvwrMzBPVA6dpsWiFTfR1XVxnliavp47YHWKYWs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lqrHoQ6V5c0myV/59ulejX82VXnshwpeVbx09moR0le6c2jZ27+JlDM19EBAKMk6R 81Zx1c3wEBJw3WDn7NgF+mXriD3q6EjSD2/iuVLq7N2/vw1qZ7SM2OZenhOUxS46/L mwmkAigPCSTXDeWu1bMdhNvJoLe6AqEjimqNKtWQ= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from purkki.adurom.net (purkki.adurom.net [80.68.90.206]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5C4D860588; Mon, 5 Nov 2018 08:07:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1541405230; bh=Zy48dvwrMzBPVA6dpsWiFTfR1XVxnliavp47YHWKYWs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=YckzqTUgXq8w/6TV85oirCRHLSOQPHk/8YcQ7AzU+0NbCJXLLdHPTuZfDibBPhBOk 5fvtSW9XyDghJwrWrR9laBU/etWn/lUYaVXrLuMaQEs79+VAJ7hF+pZu+bV1By/N0L 2tvr5BajxAqIkl+e+J1T70SzVNQTW+OAakKWHrSY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5C4D860588 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Priit Laes Cc: linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com Subject: Re: [PATCH 0/5] Use common cordic algorithm for b43 References: <87muqoar5i.fsf@purkki.adurom.net> Date: Mon, 05 Nov 2018 10:07:07 +0200 In-Reply-To: <87muqoar5i.fsf@purkki.adurom.net> (Kalle Valo's message of "Mon, 05 Nov 2018 10:02:17 +0200") Message-ID: <87in1caqxg.fsf@purkki.adurom.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kalle Valo writes: > Priit Laes writes: > >> b43 wireless driver included internal implementation of cordic >> algorithm which has now been removed in favor of library >> implementation. >> >> During the process, brcmfmac was driver was also cleaned. >> >> Please note that this series is only compile-tested, as I >> do not have access to the hardware. >> >> Priit Laes (5): >> lib: cordic: Move cordic macros and defines to header file >> brcmfmac: Use common CORDIC_FLOAT macro from lib >> brcmfmac: Drop unused cordic defines and macros >> b43: Use common cordic algorithm from kernel lib >> b43: Drop internal cordic algorithm implementation >> >> drivers/net/wireless/broadcom/b43/Kconfig | 1 +- >> drivers/net/wireless/broadcom/b43/phy_common.c | 47 +------- >> drivers/net/wireless/broadcom/b43/phy_common.h | 9 +- >> drivers/net/wireless/broadcom/b43/phy_lp.c | 13 +- >> drivers/net/wireless/broadcom/b43/phy_n.c | 13 +- >> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h | 7 +- >> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 4 +- >> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 4 +- >> include/linux/cordic.h | 9 +- >> lib/cordic.c | 23 +--- >> 10 files changed, 35 insertions(+), 95 deletions(-) > > I don't see patch 1 in linux-wireless patchwork: > > https://patchwork.kernel.org/project/linux-wireless/list/?series=38033&state=* > > Via which tree are you planning to push these? These could potentially > go via my wireless-drivers-next tree (if review goes ok) but I need to > have all five patches in patchwork. Oh, forgot to mention that please resubmit all five patches, not just patch 1, because then it's easier for me to apply them. https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#resubmit_the_whole_patchset -- Kalle Valo