Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Minas Harutyunyan <minas.harutyunyan@synopsys.com>
To:     John Keeping <john@metanate.com>,
        Minas Harutyunyan <minas.harutyunyan@synopsys.com>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "arthur.petrosyan@synopsys.com" <arthur.petrosyan@synopsys.com>
Subject: Re: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling
Thread-Topic: [PATCH] usb: dwc2: gadget: fix ISOC frame overflow handling
Thread-Index: AQHUatZW7CBOg1jSlEOevZqXY6bG3Q==
Date:   Mon, 5 Nov 2018 08:28:07 +0000
Message-ID: <410670D7E743164D87FA6160E7907A56013A79E7CE@am04wembxa.internal.synopsys.com>
References: <20181023134355.29829-1-john@metanate.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi John,=0A=
=0A=
On 10/23/2018 5:43 PM, John Keeping wrote:=0A=
> By clearing the overrun flag as soon as the target frame is next=0A=
> incremented, we can end up incrementing the target frame more than=0A=
> expected in dwc2_gadget_handle_ep_disabled() when the endpoint's=0A=
> interval is greater than 1.  This happens if the target frame has just=0A=
> wrapped at the point when the endpoint is disabled and the frame number=
=0A=
> has not yet done so.=0A=
> =0A=
> Instead, wait until the frame number also wraps and then clear the=0A=
> overrun flag.=0A=
> =0A=
> Signed-off-by: John Keeping <john@metanate.com>=0A=
> ---=0A=
>   drivers/usb/dwc2/gadget.c | 2 +-=0A=
>   1 file changed, 1 insertion(+), 1 deletion(-)=0A=
> =0A=
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c=0A=
> index 2d6d2c8244de..8da2c052dfa1 100644=0A=
> --- a/drivers/usb/dwc2/gadget.c=0A=
> +++ b/drivers/usb/dwc2/gadget.c=0A=
> @@ -117,7 +117,7 @@ static inline void dwc2_gadget_incr_frame_num(struct =
dwc2_hsotg_ep *hs_ep)=0A=
>   	if (hs_ep->target_frame > DSTS_SOFFN_LIMIT) {=0A=
>   		hs_ep->frame_overrun =3D true;=0A=
>   		hs_ep->target_frame &=3D DSTS_SOFFN_LIMIT;=0A=
> -	} else {=0A=
> +	} else if (hs_ep->parent->frame_number < hs_ep->target_frame) {=0A=
>   		hs_ep->frame_overrun =3D false;=0A=
>   	}=0A=
>   }=0A=
> =0A=
Did you tested mentioned by you scenario? If you see issue can you =0A=
provide debug log and point the issue line in the log.=0A=
=0A=
Thanks,=0A=
Minas=0A=
=0A=