Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] ARM: dts: i.MX25: add the clocks for the EPIT blocks
To:     Shawn Guo <shawnguo@kernel.org>, Martin Kaiser <martin@kaiser.cx>,
        =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= <peron.clem@gmail.com>
References: <1541093567-29205-1-git-send-email-martin@kaiser.cx>
 <20181104144614.GJ26016@tiger>
CC:     Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <fabio.estevam@nxp.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>
From:   Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Message-ID: <0298f7ec-fbff-8edb-92bb-70a736ddaf25@mentor.com>
Date:   Mon, 5 Nov 2018 10:58:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101
 Icedove/45.2.0
MIME-Version: 1.0
In-Reply-To: <20181104144614.GJ26016@tiger>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Adding Cl?ment.

On 11/04/2018 04:46 PM, Shawn Guo wrote:
> On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote:
>> The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer)
>> function blocks. Add their ipg and per clocks to the device tree.
>>
>> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> 
> Are these EPIT devices actually used in upstream kernel, or just
> somewhere else?

Cl?ment wrote a good driver, which has already passed a series of reviews,
but this clocks add-on is actually missing.

Cl?ment, can you please add clock-names property and the corresponding
functional change to your driver? Thank you in advance.

--
Best wishes,
Vladimir

>> ---
>>
>> I tried to make this similar to gpt1 and gpt2.
>>
>>  arch/arm/boot/dts/imx25.dtsi | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi
>> index b25309d26ea5..e80101847aff 100644
>> --- a/arch/arm/boot/dts/imx25.dtsi
>> +++ b/arch/arm/boot/dts/imx25.dtsi
>> @@ -388,12 +388,16 @@
>>  			epit1: timer@53f94000 {
>>  				compatible = "fsl,imx25-epit";
>>  				reg = <0x53f94000 0x4000>;
>> +				clocks = <&clks 83>, <&clks 43>;
>> +				clock-names = "ipg", "per";
>>  				interrupts = <28>;
>>  			};
>>  
>>  			epit2: timer@53f98000 {
>>  				compatible = "fsl,imx25-epit";
>>  				reg = <0x53f98000 0x4000>;
>> +				clocks = <&clks 84>, <&clks 43>;
>> +				clock-names = "ipg", "per";
>>  				interrupts = <27>;
>>  			};
>>  
>> -- 
>> 2.1.4
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel