Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp321889imu; Mon, 5 Nov 2018 01:14:01 -0800 (PST) X-Google-Smtp-Source: AJdET5dGT39W1wkdSA09tNSBrCmk+jM8w33xm2Lsuw2UoOIqUsrPjHjS/1Lnw9h6jFYdKTym7jr7 X-Received: by 2002:a17:902:3103:: with SMTP id w3-v6mr21747255plb.51.1541409241899; Mon, 05 Nov 2018 01:14:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541409241; cv=none; d=google.com; s=arc-20160816; b=SFJyKLqUPL93IFdO9PBiM5sc5uuAcnlmM1JrgwaCrHqq1ploLLtDfIQSkWDRPOzziy nwGxfgBKwFbPO3m86BM4u7uzJFHywE/0AM8ZVH9eNyVULGnv2iy3ID6HudZYb43ngBcU w5xJXeE3F8TLJJpGWalu3VGgCRnHjPA7dQ8ryZ8nFWUK7M/YFsndVmJ4H8IfCajJODGZ 30ULPqIUgrFNCZn7jB2hy5mjktY00LQFUgjVMtLyasyxD4Nr5Glp1YnueBXldyXahpNX 51zPHwPgiKK/9dOL7jei5q8bJfKsht95SEB+uqJbibWpH5gEEU4Ggh1jDapFdOe7rp7w q96w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject:dkim-signature; bh=ZaoArPrTwYU4hI21Rt0EWf2M/5RvCoKRpba4MYaagb4=; b=JzndifLGCS0hD3ko55ENuFtnjXpvrmy5hw7OLYlKdvouN4979xkvqtwF4D0JRGkOdK OBK763xU6PQDB7VWE9alTJBs/6/HgZtKfGrlquvt0z2CzEpXaHICkA3iawS6/45g9icn H1l9e06MaO8zCo3OH/Vku4BEzQVVJG7lA7u5JKvUSI3oEhtD4KCyIxtMDIp6oZBH781o wuHBxISRBh2wkZe8lMpCF4Edwd9fw468dYQdkJGs6AnWy9pYYqvPcxYjkMCezadE2I5M eWHGEOzkSoVoOTtecbi6S8Aro54huyH1e4BDNHYs/WuB1O4dt/dIlQIqx5xZGK9RIALF 8XJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=BwDJ6BHt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 97-v6si10526506plb.403.2018.11.05.01.13.46; Mon, 05 Nov 2018 01:14:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=BwDJ6BHt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728245AbeKESa2 (ORCPT + 99 others); Mon, 5 Nov 2018 13:30:28 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:44925 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726958AbeKESa1 (ORCPT ); Mon, 5 Nov 2018 13:30:27 -0500 Received: by mail-wr1-f67.google.com with SMTP id j17-v6so3449739wrq.11 for ; Mon, 05 Nov 2018 01:11:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=ZaoArPrTwYU4hI21Rt0EWf2M/5RvCoKRpba4MYaagb4=; b=BwDJ6BHthF7TMNlQsPCz6bgbiKLuNmzOMK2n0Ui7qvtP/tYJOcD49BX8zNT6nLlZ+1 kGNOJ8ObUA5StkfGgnSfnFA/jMO55epnNPclj0LT7aAvCN2e6iUgteBSyD6LrSNEbfiF /3WQzzWdqPa3OwAUf6/k4hLEGwBQAnxqFUbwY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=ZaoArPrTwYU4hI21Rt0EWf2M/5RvCoKRpba4MYaagb4=; b=pVeSePANKf3tOD/K1RwmBqcGrzJhXILD6dvQ3eOZb1rbKo3jfz2PYJoEk055nMiXOh qOFRzDwBeEmy3w69rKeQl5ePXeb5NL9zknY7mOjXkmyVSbCjQDG7fZRFOJmDLmJyV/uN FWCaciF+BaljVq9NWvJaGL2hOazukQxk0D7GqS7MVgaR1gnsLUD/ejlSozb4dnDSTCxS 4zQgxmDGV4Z3P/9472RWz8LPfQ2ePpyXr7FAGJTE/u0C5teirk+602arNTog+NEmgFoN W/792awkrRe0frMrCUPmlEnTXHIAxnVDPv0scd6SDxqw1Aw4xOJnicS7Pl2jJOwokOqg hf5Q== X-Gm-Message-State: AGRZ1gItzHz2euVznByuaKnl+csxu+jpGHbdUGUYkB5bXZnhSjcH2apk x+yMnjasNIBkfP/SbX+uO8Eg7okLGJLfoQ== X-Received: by 2002:adf:fb4b:: with SMTP id c11-v6mr18093152wrs.117.1541409103326; Mon, 05 Nov 2018 01:11:43 -0800 (PST) Received: from [10.176.68.125] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id i7-v6sm66453201wrb.30.2018.11.05.01.11.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Nov 2018 01:11:42 -0800 (PST) Subject: Re: [PATCH 5/5] b43: Drop internal cordic algorithm implementation To: Kalle Valo , Priit Laes References: <51f98dbd0efe48c315d8e7876074aeaa22fde580.1541238842.git-series.plaes@plaes.org> <87y3a7gaag.fsf@codeaurora.org> Cc: linux-kernel@vger.kernel.org, "David S. Miller" , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org From: Arend van Spriel Message-ID: Date: Mon, 5 Nov 2018 10:11:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <87y3a7gaag.fsf@codeaurora.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/5/2018 10:09 AM, Kalle Valo wrote: > Priit Laes writes: > >> Signed-off-by: Priit Laes > > No empty commit logs, please. > > And IMHO you could fold patch 5 into patch 4. Similarly 2 and 3. Regards, Arend