Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp338065imu; Mon, 5 Nov 2018 01:33:59 -0800 (PST) X-Google-Smtp-Source: AJdET5fcBWfmrMo0h+rxlCBjNAvqLX07Qj52vyp40DP1V+WOTcixDY3AITA05jozdNfl8oe3QUo3 X-Received: by 2002:a63:65c7:: with SMTP id z190mr19519731pgb.249.1541410439101; Mon, 05 Nov 2018 01:33:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541410439; cv=none; d=google.com; s=arc-20160816; b=MLr1ZvxRlt+dZVh6w0dwfaII/NySCma3maw+aIayWItzE7cv75gnXCzAO+BrnpTya3 YIMH0d6W9z4WX0mAm3QoEYZYTT7zZ9n7/P9q7Aledv27fNimx6bVC15nx7QnodLC/nOW Ylx2oHLxQhKHawr7qwJbl2DRF3eaGPa/LpHx2qBFwzx49lBRu5/VSv8VM+7MIcEgHDQx tqSe7mqQkfXP5dUopiOuuRDlryH4yclSRDNXdUjXGG8aXi9v88qYpnoUk0uD4xF4jGq6 HoqANc4rnOY73ryAhEcWtIYqTopp8OlR7tKUQI7rYby0yhQWI8sO/qsx9n/uy3aMPdho ++SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from; bh=Q5lgwwI271wuGc9mM0mSl/fwyPck+Gs4fTtsLWe1/L4=; b=fsas55s173tKCTFVNkOO/0954WD6Abi9wZuFFoItrZBDxGyA6huyUOTJCiW+cEXp4b eYWPjVwwNz1utStLrFY73NqkfQsCLfaEVyp4iKLNLUIOdZF5MGZA+r8TQA5AGTBQaIpe bDL3/+fCvBNSpa4r4iQGZZc7fShs9RAwBdTpLUETcHuFJgV/kVacKClNQLXkbaq4XBDw SVgw+p6wyExi6vs0Bq20lPp5kJ6i6x15U/TE1/WCUy0rl63NShhT/4Yg8865dGASH6NJ GXEMsnJUcW1w9fBQWDYXJjoNNhCK+EaI0bfSQC3E31fm+5J/8u6kkV5BXJjrFnE2h9fH /QDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=Zvc+a3rM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11-v6si37729377pgi.378.2018.11.05.01.33.43; Mon, 05 Nov 2018 01:33:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=Zvc+a3rM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729022AbeKESwD (ORCPT + 99 others); Mon, 5 Nov 2018 13:52:03 -0500 Received: from hqemgate16.nvidia.com ([216.228.121.65]:4941 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728971AbeKESwC (ORCPT ); Mon, 5 Nov 2018 13:52:02 -0500 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 05 Nov 2018 01:33:20 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Mon, 05 Nov 2018 01:33:12 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Mon, 05 Nov 2018 01:33:12 -0800 Received: from HQMAIL107.nvidia.com (172.20.187.13) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 5 Nov 2018 09:33:12 +0000 Received: from hqnvemgw02.nvidia.com (172.16.227.111) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Mon, 5 Nov 2018 09:33:12 +0000 Received: from niwei-ubuntu.nvidia.com (Not Verified[10.19.225.182]) by hqnvemgw02.nvidia.com with Trustwave SEG (v7,5,8,10121) id ; Mon, 05 Nov 2018 01:33:12 -0800 From: Wei Ni To: , , CC: , , , Wei Ni Subject: [PATCH v1 4/4] thermal: tegra: fix coverity defect Date: Mon, 5 Nov 2018 17:32:34 +0800 Message-ID: <1541410354-19090-5-git-send-email-wni@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1541410354-19090-1-git-send-email-wni@nvidia.com> References: <1541410354-19090-1-git-send-email-wni@nvidia.com> X-NVConfidentiality: public MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1541410401; bh=Q5lgwwI271wuGc9mM0mSl/fwyPck+Gs4fTtsLWe1/L4=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: In-Reply-To:References:X-NVConfidentiality:MIME-Version: Content-Type; b=Zvc+a3rMj0JGdW8jMbfYV9cuCTRbNaRsVXIZm8OmTVpdN/iKCkZ6uYQ3zamtqunJe SXpaARrVzKHfp25/b+5sW1hkqPd5O2poTIv7zijyDY24vEkTeEBZujpQNil6taUwBk TTl4kf2ex10OQtS82QErTzAQQFlgHdz6Q+RLunUQLxmm4SwNQxJsvtt4qw54SX74FB DBKEktTD/xQDQtHyDkp9lMYG99humDfilDvtBogGor2Q+e9cI6rY6ZWEX0KURneJ13 yyGRfYcXPw9f5vgvCWDV1xbDDjDdyE64+dbreFUXVYEQzfpxpl9XsRNfRl2w8A0UhG qq3wNiBdpyeMA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix dereference dev before null check. Signed-off-by: Wei Ni --- drivers/thermal/tegra/soctherm.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c index 3042837364e8..96527df91f2a 100644 --- a/drivers/thermal/tegra/soctherm.c +++ b/drivers/thermal/tegra/soctherm.c @@ -397,7 +397,7 @@ static int throttrip_program(struct device *dev, struct soctherm_throt_cfg *stc, int trip_temp) { - struct tegra_soctherm *ts = dev_get_drvdata(dev); + struct tegra_soctherm *ts; int temp, cpu_throt, gpu_throt; unsigned int throt; u32 r, reg_off; @@ -405,6 +405,8 @@ static int throttrip_program(struct device *dev, if (!sg || !stc || !stc->init) return -EINVAL; + ts = dev_get_drvdata(dev); + temp = enforce_temp_range(dev, trip_temp) / ts->soc->thresh_grain; /* Hardcode LIGHT on LEVEL1 and HEAVY on LEVEL2 */ -- 2.7.4