Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] kdb: fix strncpy warning
To:     Daniel Thompson <daniel.thompson@linaro.org>,
        Jason Wessel <jason.wessel@windriver.com>
Cc:     Olof Johansson <olof@lixom.net>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        kgdb-bugreport@lists.sourceforge.net
References: <20181102212405.5911-1-olof@lixom.net>
 <20181103153925.ozyb4pqnixu6hw4z@holly.lan>
 <CAOesGMjW0Ekbo0HmJak81zytLkSMeZq7=Mk8oTT8eVEED9=gEA@mail.gmail.com>
From:   Prarit Bhargava <prarit@redhat.com>
Message-ID: <2b728c10-1c76-5e7f-1aa1-c7c1dc4a7125@redhat.com>
Date:   Mon, 5 Nov 2018 06:39:56 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CAOesGMjW0Ekbo0HmJak81zytLkSMeZq7=Mk8oTT8eVEED9=gEA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 11/03/2018 12:54 PM, Olof Johansson wrote:
> On Sat, Nov 3, 2018 at 8:39 AM Daniel Thompson
> <daniel.thompson@linaro.org> wrote:
>>
>> On Fri, Nov 02, 2018 at 02:24:05PM -0700, Olof Johansson wrote:
>>> kdb does a strncpy(a, b, strlen(b)+1), which makes no sense. Might as
>>> well do a strcpy at this point.
>>>
>>> Fixes this warning:
>>>
>>> In function 'strncpy', inlined from 'kallsyms_symbol_next' at kernel/debug/kdb/kdb_support.c:239:4:
>>> ./include/linux/string.h:253:9: warning: '__builtin_strncpy' specified bound depends on the length of the source argument [-Wstringop-overflow=]
>>
>> I think we already have a pending patch for this:
>> https://lore.kernel.org/patchwork/patch/989013/
>>
>> When we looked into this there actually is an unchecked overflow here so
>> Prarit's fix adds infrastructure to keep track of the remaining length.
> 
> I'm not surprised that there are more bugs.
> 
> The above patch was posted a month and a half ago though, why is it
> not yet merged? Can we get it in by -rc2, please?
> 
> 

Jason?  ping?  Just making sure the above patch is in your queue.

P.

> -Olof
>