Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20181024032356.3388-3-vt@altlinux.org>
References: <20181024032356.3388-1-vt@altlinux.org> <20181024032356.3388-3-vt@altlinux.org>
From:   Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date:   Mon, 5 Nov 2018 14:23:13 +0100
Message-ID: <CAKv+Gu-DHURWHZdyLY5Tbw5-Te-e_-89k-R91Vv3xRKchhvkYA@mail.gmail.com>
Subject: Re: [PATCH v3 2/3] crypto: streebog - register Streebog in hash info
 for IMA
To:     Vitaly Chikunov <vt@altlinux.org>
Cc:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Kate Stewart <kstewart@linuxfoundation.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
        <linux-crypto@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 24 October 2018 at 05:23, Vitaly Chikunov <vt@altlinux.org> wrote:
> Register Streebog hash function in Hash Info arrays to let IMA use
> it for its purposes.
>
> Signed-off-by: Vitaly Chikunov <vt@altlinux.org>
> ---
>  crypto/hash_info.c             | 4 ++++
>  include/crypto/hash_info.h     | 1 +
>  include/uapi/linux/hash_info.h | 2 ++
>  3 files changed, 7 insertions(+)
>
> diff --git a/crypto/hash_info.c b/crypto/hash_info.c
> index 7b1e0b188ce6..b0b91eb0973a 100644
> --- a/crypto/hash_info.c
> +++ b/crypto/hash_info.c
> @@ -32,6 +32,8 @@ const char *const hash_algo_name[HASH_ALGO__LAST] = {
>         [HASH_ALGO_TGR_160]     = "tgr160",
>         [HASH_ALGO_TGR_192]     = "tgr192",
>         [HASH_ALGO_SM3_256]     = "sm3-256",
> +       [HASH_ALGO_SB256]       = "sb256",
> +       [HASH_ALGO_SB512]       = "sb512",
>  };
>  EXPORT_SYMBOL_GPL(hash_algo_name);
>
> @@ -54,5 +56,7 @@ const int hash_digest_size[HASH_ALGO__LAST] = {
>         [HASH_ALGO_TGR_160]     = TGR160_DIGEST_SIZE,
>         [HASH_ALGO_TGR_192]     = TGR192_DIGEST_SIZE,
>         [HASH_ALGO_SM3_256]     = SM3256_DIGEST_SIZE,
> +       [HASH_ALGO_SB256]       = STREEBOG256_DIGEST_SIZE,
> +       [HASH_ALGO_SB512]       = STREEBOG512_DIGEST_SIZE,
>  };
>  EXPORT_SYMBOL_GPL(hash_digest_size);
> diff --git a/include/crypto/hash_info.h b/include/crypto/hash_info.h
> index 56f217d41f12..91786b68dbdb 100644
> --- a/include/crypto/hash_info.h
> +++ b/include/crypto/hash_info.h
> @@ -15,6 +15,7 @@
>
>  #include <crypto/sha.h>
>  #include <crypto/md5.h>
> +#include <crypto/streebog.h>
>
>  #include <uapi/linux/hash_info.h>
>
> diff --git a/include/uapi/linux/hash_info.h b/include/uapi/linux/hash_info.h
> index eea5d02c58de..5e8b8d952ba0 100644
> --- a/include/uapi/linux/hash_info.h
> +++ b/include/uapi/linux/hash_info.h
> @@ -33,6 +33,8 @@ enum hash_algo {
>         HASH_ALGO_TGR_160,
>         HASH_ALGO_TGR_192,
>         HASH_ALGO_SM3_256,
> +       HASH_ALGO_SB256,
> +       HASH_ALGO_SB512,

Could we make this HASH_ALGO_STREEBOG_xxx please?

>         HASH_ALGO__LAST
>  };
>
> --
> 2.11.0
>