Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1541093567-29205-1-git-send-email-martin@kaiser.cx>
 <20181104144614.GJ26016@tiger> <0298f7ec-fbff-8edb-92bb-70a736ddaf25@mentor.com>
In-Reply-To: <0298f7ec-fbff-8edb-92bb-70a736ddaf25@mentor.com>
From:   =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= <peron.clem@gmail.com>
Date:   Mon, 5 Nov 2018 14:55:48 +0100
Message-ID: <CAJiuCcde0n5VGnqsXgnevKEk9KkPHf=_JMo7yyBBvX-PF_v2-A@mail.gmail.com>
Subject: Re: [PATCH] ARM: dts: i.MX25: add the clocks for the EPIT blocks
To:     Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc:     Shawn Guo <shawnguo@kernel.org>, martin@kaiser.cx,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Fabio Estevam <fabio.estevam@nxp.com>,
        NXP Linux Team <linux-imx@nxp.com>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On Mon, 5 Nov 2018 at 09:58, Vladimir Zapolskiy
<vladimir_zapolskiy@mentor.com> wrote:
>
> Adding Cl=C3=A9ment.
>
> On 11/04/2018 04:46 PM, Shawn Guo wrote:
> > On Thu, Nov 01, 2018 at 06:32:47PM +0100, Martin Kaiser wrote:
> >> The i.MX25 contains two EPIT (Enhanced Periodic Interrupt Timer)
> >> function blocks. Add their ipg and per clocks to the device tree.
> >>
> >> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> >
> > Are these EPIT devices actually used in upstream kernel, or just
> > somewhere else?
>
> Cl=C3=A9ment wrote a good driver, which has already passed a series of re=
views,
> but this clocks add-on is actually missing.
>
> Cl=C3=A9ment, can you please add clock-names property and the correspondi=
ng
> functional change to your driver? Thank you in advance.

I'm converting it with the new timer-of framework, will check for
adding both clocks.

New patch should come this week I hope.

Regards,
Clement>
> --
> Best wishes,
> Vladimir
>
> >> ---
> >>
> >> I tried to make this similar to gpt1 and gpt2.
> >>
> >>  arch/arm/boot/dts/imx25.dtsi | 4 ++++
> >>  1 file changed, 4 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dt=
si
> >> index b25309d26ea5..e80101847aff 100644
> >> --- a/arch/arm/boot/dts/imx25.dtsi
> >> +++ b/arch/arm/boot/dts/imx25.dtsi
> >> @@ -388,12 +388,16 @@
> >>                      epit1: timer@53f94000 {
> >>                              compatible =3D "fsl,imx25-epit";
> >>                              reg =3D <0x53f94000 0x4000>;
> >> +                            clocks =3D <&clks 83>, <&clks 43>;
> >> +                            clock-names =3D "ipg", "per";
> >>                              interrupts =3D <28>;
> >>                      };
> >>
> >>                      epit2: timer@53f98000 {
> >>                              compatible =3D "fsl,imx25-epit";
> >>                              reg =3D <0x53f98000 0x4000>;
> >> +                            clocks =3D <&clks 84>, <&clks 43>;
> >> +                            clock-names =3D "ipg", "per";
> >>                              interrupts =3D <27>;
> >>                      };
> >>
> >> --
> >> 2.1.4
> >>
> >>
> >> _______________________________________________
> >> linux-arm-kernel mailing list
> >> linux-arm-kernel@lists.infradead.org
> >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel