Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp664670imu; Mon, 5 Nov 2018 07:02:12 -0800 (PST) X-Google-Smtp-Source: AJdET5fwvaztFpNBD0MLTS7/mQys4LFuv04JXYqA/6GGTCDyU3ynN+llBgH1LbABsQRcl1mRmoxB X-Received: by 2002:a62:adb:: with SMTP id 88-v6mr8564903pfk.121.1541430132833; Mon, 05 Nov 2018 07:02:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541430132; cv=none; d=google.com; s=arc-20160816; b=U5VEhjiGlAOH0XEDkpY/CT6cLQE0e/bMmGm++HLjFE1f1OcN6Quv1b+FG9obA8ANxn cPNu+ajg0gSvrI2D8KduueJ3bXT3y1e70R8KvRPpZIvoL084l7q4bDEFCq3FcpLVAQkT /d+tEsEH6EhvoY2OBET5MwQGdqJfAnmaxGQp95CgnsRrCSqtoldLxg/g0P33TgyvoMqI uzNG1VYIDA1a/Xj3vf4Li231T/IOa15RxFAH5dbzBTDRfe85MjJKPuNpu+TZCbjFsQKL gjrNT+RQ8W29vymhEhtTfFVbKyeZE8sxPQybFG/MWTJGLJ85ZSr1awgFCwqUN8L1JlgD cJVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=3gYZRtrbX5ghD33CiTpEkdHxJdZHVlkk1o9milWK0P8=; b=PC/OXaf+BTDnsEL133o1eE+c+bK+sBtp16RktzuE7P2yMM6PVLrumxlqprGfglxCxl b39bL8vLxfUsxwSmCf9+Dvg0JUuY+bqzxBFV/ekcunufWvUT+MWYN/xaJIDgU3qWkx1L h/VYI4PoNRhXtPDTZIkPsbFyVQkewPjI73HM7L6K/c9x74YLk8Qfi8v4zx+u07nBaK24 2PF4vVjNQeJmWOU1CiVFTDae3SrkVLmUinCNmTbNAnFu0ZYerH7Pmwe1hhWDizSUGVGq yF2ySN7LenBjt6H/nEt9ndrgHEXY8ydVgi4pTToBKlAbDVdGWZSN0tsGtN0rOHXZDWXL QZXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KJidsjYe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8si4360094pgi.575.2018.11.05.07.01.46; Mon, 05 Nov 2018 07:02:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=KJidsjYe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729891AbeKFAVc (ORCPT + 99 others); Mon, 5 Nov 2018 19:21:32 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:34386 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729473AbeKFAVc (ORCPT ); Mon, 5 Nov 2018 19:21:32 -0500 Received: by mail-pf1-f193.google.com with SMTP id y18-v6so2162622pfn.1 for ; Mon, 05 Nov 2018 07:01:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=3gYZRtrbX5ghD33CiTpEkdHxJdZHVlkk1o9milWK0P8=; b=KJidsjYesKTgUnD+WRPbdFJRD29hlmroinWgPNnzT5eAqQdcs+HPBcV5OcZGh9pSPo LlQvA6eqg4S/wmgpK5W9aNMpFFFXRXBElTsSd5l0ktygpFApR2neMCoBdRgX8VM8sqqN iQ65iV54BISJkZfd/vJ9bT5UfE5Q+O2zQUVUGkE/EvaHw3IThjtbqkDuNrBHv56lLM6T qfVu7wtDX50eZxK0pXJQfC8oPwrlWo94aeVFyEjfyKeFrKjUZgHiodbmKixvKBTPsDU4 7eNkOrxslhEIqlIykf7SPo5cO9UwMl4Mozus3X8+YyoYhvouHOCUxadhwIn4oFBBSP75 9zpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=3gYZRtrbX5ghD33CiTpEkdHxJdZHVlkk1o9milWK0P8=; b=ezB3PgTA5s3Gr2EH9ejGyub+09WTgSZVTCSGvUehpf6EiLh1tTTA/yhxrAfYujzSfc Xle2LNdCifDP/gwBLWm0bz7IZIc2E3b9vDFexcxJXx7ON/vUNOUeJ0vD6qx1nakDDcus VlMpwy0GoVLgMsQLnSNpupUHVkptsFzGLiMm8pfLY3tUdqtQXsyiP85hlgjbu8CGzqf9 bdzkxiAYXXDxxe/FHNK6++juvFEJSNGx8Nox85tWsW10EE7D/2vAxn5KUiFIn7Z0/RKP otjqK+6tueh8xiXYL3LLGuIbjspSyBJLoRrUAZ5B+QToG7cep+hiLM27qP9435YJSa2a KAag== X-Gm-Message-State: AGRZ1gK7iKU/Wk0Kf7qCQVHcSztrfQJmkRFAFATYfm0+CGIRl4+GvArm 3GQtVC8gVLuTq+ZQCmth9Vk= X-Received: by 2002:a65:4049:: with SMTP id h9mr20159224pgp.304.1541430085070; Mon, 05 Nov 2018 07:01:25 -0800 (PST) Received: from localhost (68.168.130.77.16clouds.com. [68.168.130.77]) by smtp.gmail.com with ESMTPSA id n87-v6sm55558608pfb.62.2018.11.05.07.01.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 05 Nov 2018 07:01:24 -0800 (PST) From: Yangtao Li To: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, hbathini@linux.ibm.com, mahesh@linux.vnet.ibm.com, david@gibson.dropbear.id.au, msuchanek@suse.de Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Yangtao Li Subject: [PATCH] powerpc/fadump: Change to use DEFINE_SHOW_ATTRIBUTE macro Date: Mon, 5 Nov 2018 10:01:19 -0500 Message-Id: <20181105150119.6452-1-tiny.windzz@gmail.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yangtao Li --- arch/powerpc/kernel/fadump.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c index a711d22339ea..2df5e04b5afc 100644 --- a/arch/powerpc/kernel/fadump.c +++ b/arch/powerpc/kernel/fadump.c @@ -1531,17 +1531,7 @@ static struct kobj_attribute fadump_register_attr = __ATTR(fadump_registered, 0644, fadump_register_show, fadump_register_store); -static int fadump_region_open(struct inode *inode, struct file *file) -{ - return single_open(file, fadump_region_show, inode->i_private); -} - -static const struct file_operations fadump_region_fops = { - .open = fadump_region_open, - .read = seq_read, - .llseek = seq_lseek, - .release = single_release, -}; +DEFINE_SHOW_ATTRIBUTE(fadump_region); static void fadump_init_files(void) { -- 2.17.0