Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 5 Nov 2018 16:44:20 +0100 (CET)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Ingo Molnar <mingo@kernel.org>
cc:     linux-kernel@vger.kernel.org, shai@scalemp.com, jgross@suse.com,
        eial@scalemp.com, hpa@zytor.com, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/urgent] x86/vsmp: Remove dependency on pv_irq_ops
In-Reply-To: <20181105154139.GA124398@gmail.com>
Message-ID: <alpine.DEB.2.21.1811051644040.1566@nanos.tec.linutronix.de>
References: <1541404864-31603-1-git-send-email-eial@scalemp.com> <tip-7f2d7f8190d856949d8aaab55d3902cd10ea1048@git.kernel.org> <20181105154139.GA124398@gmail.com>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 5 Nov 2018, Ingo Molnar wrote:

> 
> * tip-bot for Eial Czerwacki <tipbot@zytor.com> wrote:
> 
> > Commit-ID:  7f2d7f8190d856949d8aaab55d3902cd10ea1048
> > Gitweb:     https://git.kernel.org/tip/7f2d7f8190d856949d8aaab55d3902cd10ea1048
> > Author:     Eial Czerwacki <eial@scalemp.com>
> > AuthorDate: Mon, 5 Nov 2018 10:01:04 +0200
> > Committer:  Thomas Gleixner <tglx@linutronix.de>
> > CommitDate: Mon, 5 Nov 2018 12:33:47 +0100
> > 
> > x86/vsmp: Remove dependency on pv_irq_ops
> > 
> > vsmp dependency on pv_irq_ops has been removed some years ago, but the code
> > still deals with pv_irq_ops.
> 
> s/vsmp
>  /vSMP
> 
> > +#if defined CONFIG_PCI
> 
> I don't think code was ever tested with PCI disabled?
> 
> The above typoed sequence of code accidentally evaluates to 'true' 
> regardless of CONFIG_PCI.

Grr. Indeed, missed that