Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [tip:x86/urgent] x86/vsmp: Remove dependency on pv_irq_ops
To:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@kernel.org>
Cc:     linux-kernel@vger.kernel.org, shai@scalemp.com, jgross@suse.com,
        hpa@zytor.com, linux-tip-commits@vger.kernel.org
References: <1541404864-31603-1-git-send-email-eial@scalemp.com>
 <tip-7f2d7f8190d856949d8aaab55d3902cd10ea1048@git.kernel.org>
 <20181105154139.GA124398@gmail.com>
 <alpine.DEB.2.21.1811051644040.1566@nanos.tec.linutronix.de>
From:   Eial Czerwacki <eial@scalemp.com>
Organization: ScaleMP
Message-ID: <c2b4c397-1789-aef0-e7fd-28abb0104c6d@scalemp.com>
Date:   Mon, 5 Nov 2018 18:40:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.21.1811051644040.1566@nanos.tec.linutronix.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Greetings,

On 11/05/2018 05:44 PM, Thomas Gleixner wrote:
> On Mon, 5 Nov 2018, Ingo Molnar wrote:
> 
>>
>> * tip-bot for Eial Czerwacki <tipbot@zytor.com> wrote:
>>
>>> Commit-ID:  7f2d7f8190d856949d8aaab55d3902cd10ea1048
>>> Gitweb:     https://git.kernel.org/tip/7f2d7f8190d856949d8aaab55d3902cd10ea1048
>>> Author:     Eial Czerwacki <eial@scalemp.com>
>>> AuthorDate: Mon, 5 Nov 2018 10:01:04 +0200
>>> Committer:  Thomas Gleixner <tglx@linutronix.de>
>>> CommitDate: Mon, 5 Nov 2018 12:33:47 +0100
>>>
>>> x86/vsmp: Remove dependency on pv_irq_ops
>>>
>>> vsmp dependency on pv_irq_ops has been removed some years ago, but the code
>>> still deals with pv_irq_ops.
>>
>> s/vsmp
>>  /vSMP
>>
>>> +#if defined CONFIG_PCI
>>
>> I don't think code was ever tested with PCI disabled?
>>
>> The above typoed sequence of code accidentally evaluates to 'true' 
>> regardless of CONFIG_PCI.
> 
> Grr. Indeed, missed that
> 
> 

actually I've tested it with CONFIG_PCI unset but evidently I've managed
to mess up the test somehow.
thanks for pointing this out, I'll send a patch that fixes it.

Eial.