Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 5 Nov 2018 19:54:16 +0200
From:   Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
To:     linux-bluetooth@vger.kernel.org
Cc:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Marcel Holtmann <marcel@holtmann.org>,
        Kay Sievers <kay.sievers@vrfy.org>,
        Zbigniew =?utf-8?Q?J=C4=99drzejewski-Szmek?= <zbyszek@in.waw.pl>,
        systemd-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] hid2hci: Fix udev rules for linux-4.14+
Message-ID: <20181105175416.GO9144@intel.com>
References: <20180507130638.3516-1-ville.syrjala@linux.intel.com>
 <20180620164240.6535-1-ville.syrjala@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20180620164240.6535-1-ville.syrjala@linux.intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jun 20, 2018 at 07:42:40PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Since commit 1455cf8dbfd0 ("driver core: emit uevents when
> device is bound to a driver") the kernel started emitting
> "bind" and "unbind" uevents which confuse the hid2hci
> udev rules.
> 
> The symptoms on an affected machine (Dell E5400 in my case)
> include bluetooth devices not appearing and udev hogging
> the cpu as it's busy processing a constant stream of these
> "bind"+"unbind" uevents.
> 
> Change the udev rules not do anything except for "add" and
> "change" events. This seems to cure my machine at least.
> 
> v2: Don't mess up "change" (Zbyszek)
>     Fix up the commit message a bit

Ping. Can someone push this?

> 
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Marcel Holtmann <marcel@holtmann.org>
> Cc: Kay Sievers <kay.sievers@vrfy.org>
> Cc: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
> Cc: systemd-devel@lists.freedesktop.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-bluetooth@vger.kernel.org
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  tools/hid2hci.rules | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/hid2hci.rules b/tools/hid2hci.rules
> index db6bb03d2ef3..5c7208af7a02 100644
> --- a/tools/hid2hci.rules
> +++ b/tools/hid2hci.rules
> @@ -1,6 +1,6 @@
>  # do not edit this file, it will be overwritten on update
>  
> -ACTION=="remove", GOTO="hid2hci_end"
> +ACTION!="add|change", GOTO="hid2hci_end"
>  SUBSYSTEM!="usb*", GOTO="hid2hci_end"
>  
>  # Variety of Dell Bluetooth devices - match on a mouse device that is
> -- 
> 2.16.4

-- 
Ville Syrjälä
Intel