Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Nadav Amit <namit@vmware.com>
To:     Peter Zijlstra <peterz@infradead.org>
CC:     Ingo Molnar <mingo@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, X86 ML <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Kees Cook <keescook@chromium.org>,
        Dave Hansen <dave.hansen@intel.com>,
        Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH v3 6/7] x86/alternatives: use temporary mm for text poking
Thread-Topic: [PATCH v3 6/7] x86/alternatives: use temporary mm for text
 poking
Thread-Index: AQHUcwQ5CMopNGTk70+f2dIwnm2sU6VBMXWAgABMjQA=
Date:   Mon, 5 Nov 2018 18:04:42 +0000
Message-ID: <EFF64D16-26DE-437E-99B5-A870921B7D5F@vmware.com>
References: <20181102232946.98461-1-namit@vmware.com>
 <20181102232946.98461-7-namit@vmware.com>
 <20181105133041.GC22467@hirez.programming.kicks-ass.net>
In-Reply-To: <20181105133041.GC22467@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: vmware.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6AE980EF71EDCD45975C6490CD42D3E0@namprd05.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e11b123-9c96-4ae2-d8a7-08d64349298d
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2018 18:04:42.5407
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR05MB5848
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Peter Zijlstra
Sent: November 5, 2018 at 1:30:41 PM GMT
> To: Nadav Amit <namit@vmware.com>
> Cc: Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org, x86@ker=
nel.org, H. Peter Anvin <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.d=
e>, Borislav Petkov <bp@alien8.de>, Dave Hansen <dave.hansen@linux.intel.co=
m>, Andy Lutomirski <luto@kernel.org>, Kees Cook <keescook@chromium.org>, D=
ave Hansen <dave.hansen@intel.com>, Masami Hiramatsu <mhiramat@kernel.org>
> Subject: Re: [PATCH v3 6/7] x86/alternatives: use temporary mm for text p=
oking
>=20
>=20
> On Fri, Nov 02, 2018 at 04:29:45PM -0700, Nadav Amit wrote:
>> +	unuse_temporary_mm(prev);
>> +
>> +	pte_unmap_unlock(ptep, ptl);
>=20
> That; that does kunmap_atomic() on 32bit.
>=20
> I've been thinking that the whole kmap_atomic thing on x86_32 is
> terminally broken, and with that most of x86_32 is.
>=20
> kmap_atomic does the per-cpu fixmap pte fun-and-games we're here saying
> is broken. Yes, only the one CPU will (explicitly) use those fixmap PTEs
> and thus the local invalidate _should_ work. However nothing prohibits
> speculation on another CPU from using our fixmap addresses. Which can
> lead to the remote CPU populating its TLBs for our fixmap entry.
>=20
> And, as we've found, there are AMD parts that #MC when there are
> mis-matched TLB entries.
>=20
> So what do we do? mark x86_32 SMP broken?

pte_unmap() seems to only use kunmap_atomic() when CONFIG_HIGHPTE is set, n=
o?

Do most distributions run with CONFIG_HIGHPTE?