Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp903601imu; Mon, 5 Nov 2018 10:30:36 -0800 (PST) X-Google-Smtp-Source: AJdET5fKaGjhjY/iIJ8TSNiE1PXTYq/UbFJvcu4LlOJKn+18UxB+IY4uL9wfcQIC8NNNSAolbzdK X-Received: by 2002:a17:902:28a8:: with SMTP id f37-v6mr23327817plb.264.1541442636465; Mon, 05 Nov 2018 10:30:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541442636; cv=none; d=google.com; s=arc-20160816; b=gzw5pqf9c8o19sdOMZ4FuGPvat1VN6tX3Yy1Wp0XOPobsY33RxbdfhK9JJ2dP3kk5+ uZLnm6UNM89zldTadA4QItDDh7r55+uo5/Gcryb9fV+cCmDzbJHli2JuK5WeEHkZhz+I 3n401UsWBUKUGTyYk/9muYzfjmDeRZSFOt7VhSr+lrPUa3OJiCOqRW+NRNc6kwJLfk/b u6z+alu0nF2wwhLmi/dhFQXNj6HdUacH/R0dvHC+pKAOuzvprlTVfbXs26vrb6fKIkIZ dOVaemf65LSbEKLKycAIl9a0HcfdCpZaccVfflD7BywUc1n/X4NIZsls4sxei1HiT7E3 SlmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=0+o+MD3BcE5IMA5ji84urbWnkmt7F6r15XTbanAxDQA=; b=eLO+qvQll9R5HDkd+ih7oYfql7o0xJggu7nlqsCbxJpXFgOCYtHrWYCLASmqrRnGr0 n40bL/tdAtz7UlqujQE9dfPLjpv6YTYwUZLkir4LDQqFNBWcJuMcP+UzUdqhd09rAsQo LiMpkMjGKqnM/MpSKkkwBPCLynst/tPZiqQ43MDFJtDn37pNQuxaDApK3euoWGgHOXhE CCCQ8a8fl0xLBbk1hMVXCX1FooPr4nwGHrieFCkY1BKP7Rw0DZJBIaI7Fot+K3rmfhCQ J3yzsXYWN3wG6xFU84pBpgJA1m3ZcicIXOo4gzicQlEB/HJzfV4Ck0YDveE8ZpgQucHA Wqxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=dDtU+Og2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z70-v6si17845555pfi.165.2018.11.05.10.30.19; Mon, 05 Nov 2018 10:30:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=dDtU+Og2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729800AbeKFDux (ORCPT + 99 others); Mon, 5 Nov 2018 22:50:53 -0500 Received: from mail-vs1-f67.google.com ([209.85.217.67]:33725 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729198AbeKFDux (ORCPT ); Mon, 5 Nov 2018 22:50:53 -0500 Received: by mail-vs1-f67.google.com with SMTP id p74so5737382vsc.0 for ; Mon, 05 Nov 2018 10:29:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0+o+MD3BcE5IMA5ji84urbWnkmt7F6r15XTbanAxDQA=; b=dDtU+Og2tLIBVMNPaO5WHWsnXDqUXbCPCN1kqj/aq3L66kP8JvVeCAnnmc36M6FhoG kByDLk+VKz1pUoJWpg++G6aIEGDQEH9TYJXr6BxILG805Y0pNqpiDi7wThDZMbO/4AO0 MKDXqCvXOyd5uP8CwVruzjiFXmomcCS4DO6JM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0+o+MD3BcE5IMA5ji84urbWnkmt7F6r15XTbanAxDQA=; b=mu1G6VRteW8i3oW4ORtsLsixHDQ29hTTmtsm07J/WVd9HURllFaq0gEdss0M564UsW 8dF9dUP5h0xbWY5Gh+xQ3h7xuWD7luy71Zd/kvRHrO/6u22ZhVDMygNqASYyS/mht11e sp9YNMsD4+yRQA8XsiZGW21wTiavUzww27VCn6TQABfhnzucUXpd312jDCfDEZJwhKFH OLkWu5hgc3OUwyoHmUhEWXVg3UlvOXIZsTdN/wKS328I4vdMJoGJXVO6g/0QHW94psAw HfwqiEnvmDsJ5o6tj+v+9ygu2nfOo5nJpkW/GOqEE8JcetFEnr/tj2m7IGy/0uIr4/tJ FpXQ== X-Gm-Message-State: AGRZ1gKhhkrwPtcIU2MbQQJSGRUv1/zsJUeWHxpQZTcsV+f/v+lHPsUq /aFOO5UR0nkFjXOOtOvwV/vQ2Fri1KY= X-Received: by 2002:a67:3a1c:: with SMTP id h28mr5476166vsa.218.1541442596632; Mon, 05 Nov 2018 10:29:56 -0800 (PST) Received: from mail-ua1-f51.google.com (mail-ua1-f51.google.com. [209.85.222.51]) by smtp.gmail.com with ESMTPSA id u18sm1322902uan.17.2018.11.05.10.29.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Nov 2018 10:29:55 -0800 (PST) Received: by mail-ua1-f51.google.com with SMTP id v24so3543516uap.13 for ; Mon, 05 Nov 2018 10:29:55 -0800 (PST) X-Received: by 2002:a9f:386c:: with SMTP id q41mr1330884uad.27.1541442595175; Mon, 05 Nov 2018 10:29:55 -0800 (PST) MIME-Version: 1.0 References: <20181023010707.153647-1-ryandcase@chromium.org> In-Reply-To: <20181023010707.153647-1-ryandcase@chromium.org> From: Doug Anderson Date: Mon, 5 Nov 2018 10:29:43 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1] spi: spi-qcom-qspi: Fix remaining driver nits To: ryandcase@chromium.org, Mark Brown Cc: linux-arm-msm , Stephen Boyd , LKML , linux-spi Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mark, On Mon, Oct 22, 2018 at 6:07 PM Ryan Case wrote: > > Address remaining comments from original driver patch series > > * Move RD_FIFO_CFG to be ordered corretly > * Expand spinlock comment > > Signed-off-by: Ryan Case > --- > > drivers/spi/spi-qcom-qspi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) No huge deal (obviously) but I noticed that you landed a batch of similar patches last night but didn't land this one. Did it fall off your radar or is there some other reason not to land it? Thanks! -Doug