Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181031113500.3763-1-malat@debian.org> <20181102.233357.1129560140046922258.davem@davemloft.net>
In-Reply-To: <20181102.233357.1129560140046922258.davem@davemloft.net>
From:   Mathieu Malaterre <malat@debian.org>
Date:   Mon, 5 Nov 2018 21:20:30 +0100
Message-ID: <CA+7wUsw7Qv=Zxeey-C0BSw=C3Zu_u=CZOU60TTJkk1ebROmUfg@mail.gmail.com>
Subject: =?UTF-8?B?UmU6IFtQQVRDSF0gbmV0OiBtb3ZlIOKAmF9femVyb2NvcHlfc2dfZnJvbV9pdGVy4oCZIA==?=
        =?UTF-8?B?cHJvdG90eXBlIHRvIGhlYWRlciBmaWxlIDxsaW51eC9za2J1ZmYuaD4=?=
To:     "David S. Miller" <davem@davemloft.net>
Cc:     LKML <linux-kernel@vger.kernel.org>, netdev@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, Nov 3, 2018 at 7:34 AM David Miller <davem@davemloft.net> wrote:
>
> From: Mathieu Malaterre <malat@debian.org>
> Date: Wed, 31 Oct 2018 12:34:59 +0100
>
> > This makes it clear the function is part of the API. Also this will
> > remove a warning triggered at W=1:
> >
> >   net/core/datagram.c:581:5: warning: no previous prototype for ‘__zerocopy_sg_from_iter’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Mathieu Malaterre <malat@debian.org>
>
> It's not part of the "API", and it shouldn't even be exported to
> modules.
>
> Only net/core/skbuff.c calls it, and that is never modular.

OK. I got confused with the EXPORT_SYMBOL(). I'll re-send moving
__zerocopy_sg_from_iter to skbuff.c.

Thanks