Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1087828imu; Mon, 5 Nov 2018 13:40:11 -0800 (PST) X-Google-Smtp-Source: AJdET5dhaZPPcB65WJfIyzO64CFxkUyupu2QtKlRbS7yjbePPIsGS96mQpFOIVGYbsiaKx8qJn1u X-Received: by 2002:a63:170c:: with SMTP id x12mr4807500pgl.364.1541454011409; Mon, 05 Nov 2018 13:40:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541454011; cv=none; d=google.com; s=arc-20160816; b=NN5LdF88kS6O7X+TrKitWCSOM7vo9DipSHSWA4zfixu8xpnYIWO4fbzxlH6K7/ngRX C+AgE/zavtBLXAcQj/kdad69y2/hnVullAt16QEn1MKBGj1blcq/nsntffUoY1TpjSz/ eKf83NF3WrMoF8SgkscbUZdZk9xY1LozGFh2+OBo+YsshbDdoMXTqGUQPHiEdbUSZq1I r0ClJ3RJHgxLBL69kMJ7Z+ZUYe40Q2Y5MkUPMn5h68TjeASc3USIZ9Jmd64tOi6Uuf3u s//0MniJW6APBvETXTwWBivzsRYVxtpRe/b0+mCzUVxr6ZkE05OQ1nSQ5T7X6Yr8sPHV SGpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=7+dJUDcku3DEU1QpHLYPKUabYOPlhqFBqUsEWJM6Fqg=; b=hozbJV64YkNl1tnvp912poGtvIJWh7T0GFTIdh0dBpVlbSADonjeov2SA7/uzEMgMn dgHzmbZvFxK0WCSmagVqaKaZglRCAYycOo9cNbPV9/uIWu95QN+ZH5MtAjXJoaMbkLQw o+Pjm1XRhtckjYzUnJCc8uk+SaCrFj4ECHzccC3Y9sz9iQmyEXm8L9+ZAAox6CIDk0IC jn+iKSSJlynSwIZ/cQbYaf/qtpeB8hck1ZlwtX3AD7oJVYVEa7MHQDoy9U0Lu7wDa5yn Vkix9rC4Qi0wSEkwLr00GL3ZfEkuzNhDurc8zcAQAftrbxI0wgCa8XYICbnCHk1wD+Hh 6xjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 66-v6si30800500pfv.38.2018.11.05.13.39.55; Mon, 05 Nov 2018 13:40:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387916AbeKFHBK (ORCPT + 99 others); Tue, 6 Nov 2018 02:01:10 -0500 Received: from bues.ch ([80.190.117.144]:45112 "EHLO bues.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387580AbeKFHBK (ORCPT ); Tue, 6 Nov 2018 02:01:10 -0500 Received: by bues.ch with esmtpsa (Exim 4.89) (envelope-from ) id 1gJmag-00060o-FF; Mon, 05 Nov 2018 22:39:22 +0100 Date: Mon, 5 Nov 2018 22:39:09 +0100 From: Michael =?UTF-8?B?QsO8c2No?= To: Priit Laes Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, "David S. Miller" , Kalle Valo , b43-dev@lists.infradead.org Subject: Re: [PATCH v2 3/3] b43: Use cordic algorithm from kernel library Message-ID: <20181105223909.61860cdd@wiggum> In-Reply-To: <77709642dacd9d855618bd9c2f3a56a88e881eaa.1541446422.git-series.plaes@plaes.org> References: <77709642dacd9d855618bd9c2f3a56a88e881eaa.1541446422.git-series.plaes@plaes.org> X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/=TxR.mRkCm2uX+V6VXlLC0t"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/=TxR.mRkCm2uX+V6VXlLC0t Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 5 Nov 2018 21:37:18 +0200 Priit Laes wrote: > Kernel library has a common cordic algorithm which is identical > to internally implementatd one, so use it and drop the duplicate > implementation. >=20 > Signed-off-by: Priit Laes This looks nice. But what is the testing status of this? Has this been tested on actual b43-LP hardware? Is the replacement algorithm exactly the same, or are there slight differences (e.g. in corner cases)? --=20 Michael --Sig_/=TxR.mRkCm2uX+V6VXlLC0t Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEihRzkKVZOnT2ipsS9TK+HZCNiw4FAlvguH0ACgkQ9TK+HZCN iw4TGxAA3rEjXSOKh/BC/zHNPYbmSGUHFPEwXSowS/EDt+0F2YwEpWEXzVGQOgiT qBxKLLcy5TyJ430lv1D9u6f0lVVyUz1sPTquT5NmIiktE7UAc4RP8w6ACbtI9OZ2 4zqsF2G15mkzE8oilxC+EI/TlLKsli4pKTWgpL+UoShSRnG9cmFbUcbi/kzW0RbC 7ciXgbqv/eirZcTREniI6e0/Qllst5NTlLLyBgXTCCg5hwLgBzO28DiJZR3ynGUD xPyyZ1NV+IfiueTCgF8DyFka1OA1uvAMsrVh8JDG1DXDlAaaS+bC8R/OUWymovcv 5+f1SbzN/ANFLzTaNzd0vle9Te4V+OY/UcytZlg1Ijlud5YRsDm5ThnzM7MVDPTa 3gfddvjte9PS+SDP4K3KcFUpnK6eZ0GuHJ1w6TEit3LAmjTxyuTV5x3iBUc0cnC3 robcDI+XKUFKj5V0Ze5GOcuZ/L1kvMTSf6GR4QWrHC2k08WTNttvgcn2zAa1qPX5 zZK0DdnMkBfUrM1PJqTrfMb6O1N+/xMlupwyGJs90pzaWdn51vrBFzjy+0O7jwTc cte2lVIec/Oy6oN5ohjkm5aPv4DGjf2q+UVfANjpldvWpG/GfQ5yG4Ip26f7XcKT ucrVAJlhgNl7jFjxdrKiqaBMEsr1Wk3jUthIJFdbwaciTBJDNGc= =Q3Le -----END PGP SIGNATURE----- --Sig_/=TxR.mRkCm2uX+V6VXlLC0t--