Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 5 Nov 2018 13:57:45 -0800
From:   Christoph Hellwig <hch@infradead.org>
To:     Zubin Mithra <zsm@chromium.org>
Cc:     tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
        linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
        groeck@chromium.org, keescook@chromium.org
Subject: Re: [PATCH] x86/pci: Annotate 'pci_root_ops' with __ro_after_init
Message-ID: <20181105215745.GB3160@infradead.org>
References: <20181105201735.72026-1-zsm@chromium.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181105201735.72026-1-zsm@chromium.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 05, 2018 at 12:17:35PM -0800, Zubin Mithra wrote:
> When CONFIG_X86_INTEL_MID is set pci_root_ops is written to inside
> intel_mid_pci_init(which is marked __init) and not modified after. This
> makes pci_root_ops a suitable candidate for annotating as
> __ro_after_init.

Yikes.  pci_root_ops really should be const to start with, and we
should use a separate struct for MID.  Having structures that contain
function pointers not marked const is generally a bad idea to start with.