Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1106872imu; Mon, 5 Nov 2018 14:03:42 -0800 (PST) X-Google-Smtp-Source: AJdET5ewfaYB+5RXLpFAAfd0ke4cTieD4S1sk9urv7wx6eFgW34tu5NiR3TA/yL63H7ZFCOF/DPs X-Received: by 2002:a63:7cf:: with SMTP id 198mr19203894pgh.129.1541455422905; Mon, 05 Nov 2018 14:03:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541455422; cv=none; d=google.com; s=arc-20160816; b=oEhFYiMsqHvtUfzMxcrHdbSIB+azz6BpwspACcPyAXNw9Yareqy9AVkyh/EI0EVwes CKz1SgjU+QXt2PqysD/Wnu9+zgFfV5Jj2sKvQkGpwFoF/T9R8wZfJn6+zYoHKsxAuuv0 aGX53iYLgwfYi+IOLkY+npn0S2FLYSjoN6y6M5JR7/PKWauLg6crBQxOGQIMMED/sZiP 059ecrk2pmf4uKy+V54a6bllG/vTcHe7cuXB7y6BSZDeqPUwpQr9y7wc5AG80sVZN/rK Qf9H9jOCdI9vwFYt6WvNVqsD6lXVp+ruU1tV6OuK7/CTOD/cPXnElsvrORyBN0x/Djc6 uSYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:cc:references:to :subject:dkim-signature; bh=OZxo+gm2aB0BOXCTrFO73DgYTbgCEUapMma32xYFIec=; b=f1ixp9o8vz2awvP8s87yEbLZTcIqnfaNI6OySp6uesyukGyJlF3VnLrgoh9M1vlWk2 gsORwS1JDDNfHhm3JS0DX+h0kLL2yPaEui+ybwUtIjCIVrews+zKxMkzGBqSj/Qelwy8 8MnyFgEOh5l6oazWe1hhg4zp9Ta3bHzE2Q3k43QgM24XBPp+dppFbXGUSvWsnzRNWaEs fRVY1kpClqQUDfAtFIAF3eKCC7cY8EPOzH9TJfhBvjDvQQj6mgSnXyzXoZkLQRW5Ph9g 6HhlqKFtLAIDo9lg8//zFM2IKw8ff+0ogmFg+pDgOHxYgpN4XhthvGgQF4V3M/ZdJwuL 1u4A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=UE73fprh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h25si13245945pgi.474.2018.11.05.14.03.27; Mon, 05 Nov 2018 14:03:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=UE73fprh; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388124AbeKFHY2 (ORCPT + 99 others); Tue, 6 Nov 2018 02:24:28 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:46391 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387580AbeKFHY2 (ORCPT ); Tue, 6 Nov 2018 02:24:28 -0500 Received: by mail-pg1-f193.google.com with SMTP id w7so4823681pgp.13 for ; Mon, 05 Nov 2018 14:02:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=OZxo+gm2aB0BOXCTrFO73DgYTbgCEUapMma32xYFIec=; b=UE73fprhlHvnloJPFU9DYczSaJFeBh7y3morvwmatxQ6K+wF4iz6CAFkSihGSlQ3Xy h+My48pyDLjsnG3qK2amm7jKEJITqoG2CIq6vdt4Fil1kEhJ6/gHt/km0WLQXuE0VPy0 meuWlK+47i4qUH86KU2Wfc7kt6pvjOJtfOxh8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=OZxo+gm2aB0BOXCTrFO73DgYTbgCEUapMma32xYFIec=; b=flZxFXIjpzO/Nr2NXEXy1w+CnPsMk3OSQziNbeoe6w8ueVvhtKrtByUVoGS1AoQZan XWB7wmQvi5iNhrC8/Sl6eUrVryYiGFn0QBLhjeGiBV+d2QNHHFHySeESGqhgg4+ChvFZ rY0PVRCp2MXp4u/TaiPoJK/buAVDGRBRtWDAwfNwzmWEd4Zc3vKtz+I9rkUH6l1DoQYn j/Ub54S4dgm9xMPJTUG3liLk4Gg9JYQHMu6olOLaJu1JUMLzzccTy9VZh3UYRDp0ml/k UJ1cAjqR9LSiub1c6yz767l3dQd/G/2dvJTPHJFyPzWe2jqFiAkl8syTcZ2MVHbBlgd0 nT/g== X-Gm-Message-State: AGRZ1gJ8V3w5+yYcr3m0ha/sDr4DPDRY7KaOplhqM/IEGgf7gSbLEcsI yWpO8szp/chj3XSl3JEQXtIKaQ== X-Received: by 2002:a63:81c7:: with SMTP id t190mr19113673pgd.393.1541455359260; Mon, 05 Nov 2018 14:02:39 -0800 (PST) Received: from [10.177.251.60] ([192.19.248.250]) by smtp.gmail.com with ESMTPSA id q1sm25712165pgs.14.2018.11.05.14.02.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Nov 2018 14:02:38 -0800 (PST) Subject: Re: [PATCH v2 1/3] lib: cordic: Move cordic macros and defines to header file To: Priit Laes , linux-kernel@vger.kernel.org References: <3be396e01b33905e9ac5c80e7038b7aacf72eaf8.1541446422.git-series.plaes@plaes.org> Cc: linux-wireless From: Arend van Spriel Message-ID: <8eb0e232-d14b-60d9-e3c8-008c46659a30@broadcom.com> Date: Mon, 5 Nov 2018 23:02:35 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <3be396e01b33905e9ac5c80e7038b7aacf72eaf8.1541446422.git-series.plaes@plaes.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/5/2018 8:37 PM, Priit Laes wrote: > Also append CORDIC_ prefix to nonprefixed macros. Bit annoying that you made me look at LKML for this patch. Can you just post the entire series to linux-wireless so Kalle can take it all through his tree. Also the commit message is a bit thin. Please explain why these are moved to the header file. Reviewed-by: Arend van Spriel > Signed-off-by: Priit Laes > --- > include/linux/cordic.h | 9 +++++++++ > lib/cordic.c | 23 +++++++---------------- > 2 files changed, 16 insertions(+), 16 deletions(-)