Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1208524imu; Mon, 5 Nov 2018 16:04:19 -0800 (PST) X-Google-Smtp-Source: AJdET5dGePJQ6ivC2Jj7Vthx9wd7eYOHiIxZXcNWNTgjNPBQtHIYROLlkeVAg8XyTkWcsI/68Qg7 X-Received: by 2002:a17:902:6909:: with SMTP id j9-v6mr23320355plk.221.1541462659284; Mon, 05 Nov 2018 16:04:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541462659; cv=none; d=google.com; s=arc-20160816; b=CCPutkedPbLgSX+r3ruFiULAh72Wd8V+oHhCwtbXXrjf0hryOoTnYIf+GOW4IWILC+ Q4/QEpDGWe7K0JHRGPJc6pdlTIbhAF7fIo9RdGKepulpkO63TuPhBxyUwondbOSl53jY jyxobT1+om9d8DXNAqlI+wN0eHlKz8ba70EJ+T54HC4QOA+cIut9DmTGY+Fbys2bE7Xq IKdqH6WwZLUVD7t2WdWXuo8BJ0FlPpwDv497J1ixU8oc4x9ggTkTP/MRU8VWqtiEC4UY pzHgrVqlghLaN139cr1MbhM+4GpmoRCXG+IT6lhgy3pP+MJMJzXCwwnATcsySHje4ghn ZVuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=76fZ14GYGbbBgsenkR/Fwdtk6Bt2MI68cayoBnSXa80=; b=co0vgFmwKKOonG/v2jSEeZZ4JXwXyWeFtlc6Kc7xNnCAUOHwJ5MZoU0d9WAS4LC/cW Jne17QK7oloUAet3emuWMrLb8HU1zY7u9hE6XZRadlzdvHbLeNhHSljExNSud7LoYIwi ecnDQhAGVPNmZi09mlOfqjGzs1pJFikl1vggJDxY8EiSrMHV/H8rxFVWvdBaubdxksyl FIMNwYxuVOI02JquBgSBgqIxLBbRo/vCqrXngFYp6XbKxgU6gtrUteoUbZk3M7TIBuNt vfpW6NVZT9HPMdAj983rm4OWc+s7xddLNsVMNwewB07L5rHwiYDiPFsYRm30Zv6Mt1Wj ZyWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="eSrrn/pP"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f1-v6si28618174pfg.121.2018.11.05.16.04.03; Mon, 05 Nov 2018 16:04:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="eSrrn/pP"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726945AbeKFJZg (ORCPT + 99 others); Tue, 6 Nov 2018 04:25:36 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:45440 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725844AbeKFJZg (ORCPT ); Tue, 6 Nov 2018 04:25:36 -0500 Received: by mail-ot1-f65.google.com with SMTP id g10so9807955otl.12 for ; Mon, 05 Nov 2018 16:03:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=76fZ14GYGbbBgsenkR/Fwdtk6Bt2MI68cayoBnSXa80=; b=eSrrn/pPYvpmX78yh7vclOKBuGWl2o0+dv16piMKHM5BQWcMhJ4XZKN7dYJuotjcRp 9xJxB4k/nCDViN4xiRHNlRw6tA8FwWXAqtO49SCq2Bisp73xMOQkPI9txNtBrMxEFekA HKzYF9eEMYXx/zVW8Vg0e+Ls5VISGr53sYLXM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=76fZ14GYGbbBgsenkR/Fwdtk6Bt2MI68cayoBnSXa80=; b=JBU7LnIF79IPIz0Trgva1CMokIrp5sppFpSBQaJwx4TCiU6R45GG1BxDoX47rpi2G6 0VDgtbWjfXGxgdFo+3Mm+E6GSznw4/GeqfMljtbVUHFpIXkSqch9et7ALru1GPB0OQbf 7uElkkgSB1O0lRtZCtXmZVI4WT9KT1Qx+oeNhO0Op75/J3ZXP/AsezU9grxjTyoNDFOv JmOahYpatQk/OvcHvxsV4KVxEeAzi+QoCNv3QSy1NwH/NSJttESzTwFnqK+i5pSByMWj WoC1pb6XH2ZcQI1cAY6lCIwzC7BTSfpkydsmcV56h5UAw1jy4EUK4TKmYhgldm9ktwYX nGcw== X-Gm-Message-State: AGRZ1gJvbFSH1PcwXDNK4/edQ74aWY+qHAnf8h8BNoZ0vP13jFG4rdPV j85Iot0/a1uApKJNUlTfmHFjJaPtGT9dc8Hcos7G X-Received: by 2002:a9d:5755:: with SMTP id x21mr15638811oti.193.1541462597725; Mon, 05 Nov 2018 16:03:17 -0800 (PST) MIME-Version: 1.0 References: <20181105111348.182492-1-vovoy@chromium.org> <20181105130209.GI4361@dhcp22.suse.cz> <20181105164135.GM4361@dhcp22.suse.cz> In-Reply-To: <20181105164135.GM4361@dhcp22.suse.cz> From: Kuo-Hsin Yang Date: Tue, 6 Nov 2018 08:03:06 +0800 Message-ID: Subject: Re: [PATCH v4] mm, drm/i915: mark pinned shmemfs pages as unevictable To: mhocko@kernel.org Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, Chris Wilson , Joonas Lahtinen , Peter Zijlstra , Andrew Morton , Dave Hansen Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 6, 2018 at 12:41 AM Michal Hocko wrote: > On Mon 05-11-18 22:33:13, Kuo-Hsin Yang wrote: > > OK, this function should not be specific to shmem pages. > > > > Is it OK to remove the #ifdef SHMEM surrounding check_move_unevictable_pages? > > Yes, I think so. Thanks for you review.