Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1280832imu; Mon, 5 Nov 2018 17:37:34 -0800 (PST) X-Google-Smtp-Source: AJdET5ebUM9auIDluRezOqkbqmg47LrjzZIVERrkRcVA0kAb71YloNWKGAwL2GtpIkkgzZRr+yI/ X-Received: by 2002:a63:e70a:: with SMTP id b10-v6mr21417036pgi.363.1541468254591; Mon, 05 Nov 2018 17:37:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541468254; cv=none; d=google.com; s=arc-20160816; b=fCzg8SekQsZndkD5VCGuZ6JUKJ9QX+MVaxV2kjWdAmYVb2I5QJLKA2ba13XbIxKUfN W6W87zN79aNGY/6jpmzFH3mA23ry3MwGsRmrY4YA+O0ip7yg8bIXyQ4l1e54VtWJg6e6 Ruds0AAtbPEHxRtlsbwRG9roy+P7S11CmtIZ6s++hJI4JLTGFgC0WeDXZ6ZdRhSEK72R LmeSvqDhE/XmWYL2WXmqhAUXL75wgKBwMezLhYH/je1r/T09qHPL5D39a9XhTpfBUvNO MM+w/gha5xY9tXJ/z4mK0cjuTTnNMQK09SyGF77/dp3A2wp6oH5F2MX0coeZC8PaVzfo Q/lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:references:message-id:date :thread-index:thread-topic:subject:cc:to:from; bh=Wf9fce05Xs/v3LTLXq+DEMG2V/eBfaxmucG+JUmAT+0=; b=OWri8mLCBeepRdjeWE+cQZwGmNfTsYOwPTE/59DlmlTEbZeNzXLO3UyHfRrtmfm3ee P+eW2WcgIh/4MXaoe5LG2KwdzuLz898eRCAc99AjQv4lv8eMnXmj5kdc/lb8IxV3ELF4 fpiOTerFBY6uUH0NXnZj4pXtiSPm0NIhNixIf6PIfiU8voUkBADu0voDcZeDAacdt6Zv /qz63byKcdx8BwUUpai0o85s/Qs6XvM/nE/ISNbzKt33cSqqO7J/s+TSD4dTubmoix0v izfuMLUdxmlIpwzAeneetrDycw8pqe9k+67C1Hc2TVv+DIG04INmsCCzBpYAi/d6HuCr +0YA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b9si13379616pgt.293.2018.11.05.17.37.18; Mon, 05 Nov 2018 17:37:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729205AbeKFK5f convert rfc822-to-8bit (ORCPT + 99 others); Tue, 6 Nov 2018 05:57:35 -0500 Received: from mx01.hxt-semitech.com ([223.203.96.7]:34040 "EHLO barracuda.hxt-semitech.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725910AbeKFK5f (ORCPT ); Tue, 6 Nov 2018 05:57:35 -0500 X-ASG-Debug-ID: 1541468080-093b7e4bb101d80001-xx1T2L Received: from HXTBJIDCEMVIW01.hxtcorp.net ([10.128.0.14]) by barracuda.hxt-semitech.com with ESMTP id VkSwohwyxwXYdl5b (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NO); Tue, 06 Nov 2018 09:34:40 +0800 (CST) X-Barracuda-Envelope-From: shunyong.yang@hxt-semitech.com Received: from HXTBJIDCEMVIW01.hxtcorp.net (10.128.0.14) by HXTBJIDCEMVIW01.hxtcorp.net (10.128.0.14) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 6 Nov 2018 09:34:07 +0800 Received: from HXTBJIDCEMVIW01.hxtcorp.net ([fe80::f451:a443:c0b5:87d1]) by HXTBJIDCEMVIW01.hxtcorp.net ([fe80::f451:a443:c0b5:87d1%12]) with mapi id 15.00.1395.000; Tue, 6 Nov 2018 09:34:07 +0800 From: "Yang, Shunyong" To: Sinan Kaya , "bhelgaas@google.com" CC: "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "okaya@codeaurora.org" , "Zheng, Joey" Subject: Re: [PATCH] PCI: Add HXT vendor ID and ACS quirk Thread-Topic: [PATCH] PCI: Add HXT vendor ID and ACS quirk X-ASG-Orig-Subj: Re: [PATCH] PCI: Add HXT vendor ID and ACS quirk Thread-Index: AQHUdLXdxwZYUqZPBkaNFsBxAdjg4g== Date: Tue, 6 Nov 2018 01:34:07 +0000 Message-ID: <946ea4b463a44113b6eb84f6b8e5e3f2@HXTBJIDCEMVIW01.hxtcorp.net> References: <1541387759-2336-1-git-send-email-shunyong.yang@hxt-semitech.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.64.6.144] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Barracuda-Connect: UNKNOWN[10.128.0.14] X-Barracuda-Start-Time: 1541468080 X-Barracuda-Encrypted: ECDHE-RSA-AES256-SHA384 X-Barracuda-URL: https://192.168.50.101:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at hxt-semitech.com X-Barracuda-BRTS-Status: 1 X-Barracuda-Bayes: INNOCENT GLOBAL 0.2319 1.0000 -0.6641 X-Barracuda-Spam-Score: -0.66 X-Barracuda-Spam-Status: No, SCORE=-0.66 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=9.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.61276 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Sinan, On 2018/11/6 7:12, Sinan Kaya wrote: > On 11/4/2018 7:15 PM, Shunyong Yang wrote: >> Add the HXT vendor ID to pci_ids.h and use it in quirks. As the >> design of HXT SD4800 ACS feature is the same as QCOM QDF2xxx, >> pci_quirk_qcom_rp_acs() is reused for SD4800 quirk. >> >> Cc: Joey Zheng >> Signed-off-by: Shunyong Yang > > There is also a couple of hotplug quirks for QDF2400. You should > probably take care of those as well. > > Assuming your PCI IDs are correct: > > Reviewed-by: Sinan Kaya > Thanks for your review and information. I will check the changes. Shunyong.