Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1454422imu; Mon, 5 Nov 2018 21:49:59 -0800 (PST) X-Google-Smtp-Source: AJdET5cF/0qmwqRMhHhRAWjKRXRNyCCCaQSSr+JenIf8WzAn4++I809OBdeNXbV9Ek7rRyXBzLGT X-Received: by 2002:a17:902:a9:: with SMTP id a38-v6mr13482204pla.7.1541483399852; Mon, 05 Nov 2018 21:49:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541483399; cv=none; d=google.com; s=arc-20160816; b=AjBNqGY5HMmQ39PF2wL4rBtvSEzTw1NGvb0N3/fbXNdjwe+uFpypYoTYqUw2ZwQZSh AK9wZRFXNCRuMkR4U03MAGKewCeEYDVt0nANd1ttFRoWPTH7MZrR/Lrw/drZIGy92CH9 8QX2b46/p3zJr3i2YkBoRGILc+7Dxu2oH0lmBeeR5Y06iOKqeuWynBCrKrQIk/hcbK0S SgmC1ELBUrZ8Z5WqZtH10HtZet3gWaG9yZEAscGDSaXvs2PKpjCKZRfgpoFkcfm0Bn4/ UtqArbRPgtfbjDMMJDZzbR81/jl7GhDHl0SdymgIPUE9gLey/NxwjSY1W80SJgcIkCQm W26g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=4LwowTDtfYplnEwXOTM3mt93AFvPcr5JvLq9x45Pn8s=; b=IItlzRUf25knR1hbOyLV+JNwAu0oamVNGYEVdrmQaUeXV9F0q1FboXNg618QYtXLdE hdpxADTSc6QKQozNFZrK5D1EsmFlDQcE2cC6FhQWZ+zsaIqJCCyvxaBChRuC+KOgMgvV PtKSJjPK2Q/psX2LzmH491Z0z58eK++lhQzoSYe6MId1GpNIEepiW2ScWXL4jzYn0FAB DbkblaWx3hegUM6Ab+IyLj2nhsVEObTeR9tyuqgOmAIWLqciTofS6jFojoTPBOP6E9m/ fLbNg00WH6Ohby13GRaqD57bLMSIU8EsiZRsLoOonRJjqN6oFmezCDkGzeAqPCLNQHei HLsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z32-v6si35882601pgk.507.2018.11.05.21.49.42; Mon, 05 Nov 2018 21:49:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387407AbeKFPMx (ORCPT + 99 others); Tue, 6 Nov 2018 10:12:53 -0500 Received: from mga12.intel.com ([192.55.52.136]:6015 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729319AbeKFPMx (ORCPT ); Tue, 6 Nov 2018 10:12:53 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2018 21:49:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,470,1534834800"; d="scan'208";a="271694568" Received: from unknown (HELO localhost) ([10.249.254.149]) by orsmga005.jf.intel.com with ESMTP; 05 Nov 2018 21:49:13 -0800 Date: Tue, 6 Nov 2018 07:49:11 +0200 From: Jarkko Sakkinen To: Dave Hansen Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-sgx@vger.kernel.org, sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, serge.ayoun@intel.com, shay.katz-zamir@intel.com, haitao.huang@intel.com, mark.shanahan@intel.com, andriy.shevchenko@linux.intel.com, Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "open list:DOCUMENTATION" , open list Subject: Re: [PATCH v15 23/23] x86/sgx: Driver documentation Message-ID: <20181106054911.GA15575@linux.intel.com> References: <20181102231320.29164-1-jarkko.sakkinen@linux.intel.com> <20181102231320.29164-24-jarkko.sakkinen@linux.intel.com> <154ded23-fd1d-f324-4e0a-9de8eddcda6d@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <154ded23-fd1d-f324-4e0a-9de8eddcda6d@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 05, 2018 at 12:27:11PM -0800, Dave Hansen wrote: > The ABI seems entirely undocumented and rather lightly designed, which > seems like something we should fix before this is merged. ABI is documented in arch/x86/include/uapi/asm/sgx.h that from which the documentation is included to intel_sgx.rst. I'm not saying that there is no space refine it but it is neither undocumented. > Also, for a feature as massive and complicated as this one, it seems > irresponsible to not have a selftest. Is that not feasible for some reason? I do have the in-kernel launch enclave stuff backed up here: https://github.com/jsakkine-intel/sgx-le-host https://github.com/jsakkine-intel/sgx-le This is about as simple as it gets without any type of run-time. /Jarkko