Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1477614imu; Mon, 5 Nov 2018 22:20:51 -0800 (PST) X-Google-Smtp-Source: AJdET5fuAXZDq06x2tLMRtaeMhuHYOt1jNyiwK52nKTYY1eQJ6rKpa83tVi/0j2YeCW0GrEGrZiZ X-Received: by 2002:a17:902:4623:: with SMTP id o32-v6mr24907511pld.187.1541485251326; Mon, 05 Nov 2018 22:20:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541485251; cv=none; d=google.com; s=arc-20160816; b=sS2K3dAOcDCqUvWOVXLFyMcHSJGsHMMWYTppEiQCplhUlo9M2KXca0wLfThEKfFAr9 pUcWEHh0ix7lXYvRDjeRR0Dou+6d9PizmYGLJlYfhxtvcvyZ7smiIuacxm+6DmzWp7IS VlVLmuIhk6MyRG0Z1dmtwDNF5wec1kfAt4ThXFkeV21V65tx6aEFC0aJFkqrAfwVXMMq HAh0WUcS1+HG2d8ewsRdGLHSlrfQVCov0mCsep1LHbfx0M0b5axCPYEdr0texl2ylTzy c/1bNPrN3CLPhbIVfIybxCP0gOjukkZu1XBk6yWzRg9cXJvkhcyktLILTa3ppLWHe4FN F6Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=NWhw13f693iaqCwZCEx0nsrX/lfyJbca/HLTsHI06UI=; b=JpKxS8PzelAVGVSdUlSBeemaxpoOkozSpn1UiZ80BHAXLNkaf1pzfU0JqFKGL/zDi2 H4AQWOzj3gmWc3EonOsxcdOxFi8VGlmVA+SFhb/r+MDFihd64OHdDj8A2e9VjkftiJrK EQkECYREtjb0SvTvRtlH15NINuJ6UXtbJDMIpUut9CX4kJi9WLPSvN7Ct3SByrqdivEK 5HaZmuvBYekVQXRoOzHWd3aXITfLVi/JrJk2KdoysGiHQUVt2X/rWcYnqqYDVg/43b78 cdHkKdDHV7uysa4EzQBChRmPAFPrvFdlDRtq2TjynHD4r+jAIDY4xBiR6N+p3T2psgth bLSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q17-v6si23907226pgd.438.2018.11.05.22.20.33; Mon, 05 Nov 2018 22:20:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729945AbeKFPnu (ORCPT + 99 others); Tue, 6 Nov 2018 10:43:50 -0500 Received: from mga04.intel.com ([192.55.52.120]:37725 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729416AbeKFPnu (ORCPT ); Tue, 6 Nov 2018 10:43:50 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2018 22:20:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,470,1534834800"; d="scan'208";a="271702801" Received: from unknown (HELO localhost) ([10.249.254.149]) by orsmga005.jf.intel.com with ESMTP; 05 Nov 2018 22:20:03 -0800 Date: Tue, 6 Nov 2018 08:20:02 +0200 From: Jarkko Sakkinen To: Dave Hansen Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-sgx@vger.kernel.org, sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, serge.ayoun@intel.com, shay.katz-zamir@intel.com, haitao.huang@intel.com, mark.shanahan@intel.com, andriy.shevchenko@linux.intel.com, Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "open list:DOCUMENTATION" , open list Subject: Re: [PATCH v15 23/23] x86/sgx: Driver documentation Message-ID: <20181106062002.GA18360@linux.intel.com> References: <20181102231320.29164-1-jarkko.sakkinen@linux.intel.com> <20181102231320.29164-24-jarkko.sakkinen@linux.intel.com> <154ded23-fd1d-f324-4e0a-9de8eddcda6d@intel.com> <20181106054911.GA15575@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181106054911.GA15575@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 06, 2018 at 07:49:11AM +0200, Jarkko Sakkinen wrote: > On Mon, Nov 05, 2018 at 12:27:11PM -0800, Dave Hansen wrote: > > The ABI seems entirely undocumented and rather lightly designed, which > > seems like something we should fix before this is merged. > > ABI is documented in arch/x86/include/uapi/asm/sgx.h that from which the > documentation is included to intel_sgx.rst. I'm not saying that there is > no space refine it but it is neither undocumented. > > > Also, for a feature as massive and complicated as this one, it seems > > irresponsible to not have a selftest. Is that not feasible for some reason? > > I do have the in-kernel launch enclave stuff backed up here: > > https://github.com/jsakkine-intel/sgx-le-host > https://github.com/jsakkine-intel/sgx-le > > This is about as simple as it gets without any type of run-time. Of course the enclave could be simplified considerably since now it has full code for EINITTOKEN generation, which is probably an overkill for a selftest. It could be simple as just enter and return to and from enclave or something in-between in terms of complexity. Even for the simplest enclave you need a signing tool (see sgxsign.c in my sgx-le repository), a custom linker script and a sophisticated makefile. /Jarkko