Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 6 Nov 2018 07:14:55 +0000
From:   Priit Laes <plaes@plaes.org>
To:     Arend van Spriel <arend.vanspriel@broadcom.com>
Cc:     linux-kernel@vger.kernel.org,
        linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 1/3] lib: cordic: Move cordic macros and defines to
 header file
Message-ID: <20181106071455.ch6wooqibm76tyjl@plaes.org>
References: <cover.9ec98292c595a111ae78f31383ff8618c9cb04da.1541446422.git-series.plaes@plaes.org>
 <3be396e01b33905e9ac5c80e7038b7aacf72eaf8.1541446422.git-series.plaes@plaes.org>
 <8eb0e232-d14b-60d9-e3c8-008c46659a30@broadcom.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8eb0e232-d14b-60d9-e3c8-008c46659a30@broadcom.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Nov 05, 2018 at 11:02:35PM +0100, Arend van Spriel wrote:
> On 11/5/2018 8:37 PM, Priit Laes wrote:
> > Also append CORDIC_ prefix to nonprefixed macros.
> 
> Bit annoying that you made me look at LKML for this patch. Can you just post
> the entire series to linux-wireless so Kalle can take it all through his
> tree. Also the commit message is a bit thin. Please explain why these are
> moved to the header file.

Sorry, I messed up again while trying to automate the send-email with
get_maintainers script (dry-run argument did not work .gitconfig :S)

> 
> Reviewed-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> > Signed-off-by: Priit Laes <plaes@plaes.org>
> > ---
> >  include/linux/cordic.h |  9 +++++++++
> >  lib/cordic.c           | 23 +++++++----------------
> >  2 files changed, 16 insertions(+), 16 deletions(-)
>