Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181031230541.28822-1-sashal@kernel.org> <20181031230541.28822-118-sashal@kernel.org>
In-Reply-To: <20181031230541.28822-118-sashal@kernel.org>
From:   Jack Wang <jack.wang.usish@gmail.com>
Date:   Tue, 6 Nov 2018 08:37:32 +0100
Message-ID: <CA+res+QxUmb2B=Owy3+PV_Jgsm0DBshF3RYzhcTEMnGepOZ_qg@mail.gmail.com>
Subject: Re: [PATCH AUTOSEL 4.19 118/146] MD: fix invalid stored role for a disk
To:     sashal@kernel.org
Cc:     stable@vger.kernel.org, linux-kernel@vger.kernel.org, shli@fb.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Sasha Levin <sashal@kernel.org> =E4=BA=8E2018=E5=B9=B411=E6=9C=881=E6=97=A5=
=E5=91=A8=E5=9B=9B =E4=B8=8A=E5=8D=8812:45=E5=86=99=E9=81=93=EF=BC=9A
>
> From: Shaohua Li <shli@fb.com>
>
> [ Upstream commit d595567dc4f0c1d90685ec1e2e296e2cad2643ac ]
>
> If we change the number of array's device after device is removed from ar=
ray,
> then add the device back to array, we can see that device is added as act=
ive
> role instead of spare which we expected.
>
> Please see the below link for details:
> https://marc.info/?l=3Dlinux-raid&m=3D153736982015076&w=3D2
>
> This is caused by that we prefer to use device's previous role which is
> recorded by saved_raid_disk, but we should respect the new number of
> conf->raid_disks since it could be changed after device is removed.
>
> Reported-by: Gioh Kim <gi-oh.kim@profitbricks.com>
> Tested-by: Gioh Kim <gi-oh.kim@profitbricks.com>
> Acked-by: Guoqing Jiang <gqjiang@suse.com>9e753ba9b9b405e3902d9f08aec5f2e=
a58a0c317
> Signed-off-by: Shaohua Li <shli@fb.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
Hi Sasha,

This patch breaks linear hotadd please also include  commit
9e753ba9b9b405e3902d9f08aec5f2ea58a0c317
MD: fix invalid stored role for a disk - try2

Regards,
Jack Wang

> ---
>  drivers/md/md.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 8668793262d0..85459c17cc60 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -1776,6 +1776,10 @@ static int super_1_validate(struct mddev *mddev, s=
truct md_rdev *rdev)
>                         } else
>                                 set_bit(In_sync, &rdev->flags);
>                         rdev->raid_disk =3D role;
> +                       if (role >=3D mddev->raid_disks) {
> +                               rdev->saved_raid_disk =3D -1;
> +                               rdev->raid_disk =3D -1;
> +                       }
>                         break;
>                 }
>                 if (sb->devflags & WriteMostly1)
> --
> 2.17.1
>