Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1617787imu; Tue, 6 Nov 2018 01:20:11 -0800 (PST) X-Google-Smtp-Source: AJdET5foHtEO0nEvwWMiYXVBZvQ2zXmtyBxfBtinCvVlRW4eZ0TQsJpeofP3UOILog00KJAR4lvr X-Received: by 2002:a17:902:104:: with SMTP id 4-v6mr16431383plb.184.1541496011824; Tue, 06 Nov 2018 01:20:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541496011; cv=none; d=google.com; s=arc-20160816; b=vbmUiTwAZR3PKoj351eAZ+xRcQTcvZKG0m0PfvEMWfhzyoGlEK4QtSuy5kEGKDIpBy CGkA+9J8YCQCmYZsuGZmy9XCFZMX1qqRxgqVLUtR5Hx4EXYTuOwHkRANJmKTVV0cHeF1 sGMWsm56STYa4uf8iipVp61aezX6Nw96ePWIKY7QaxCKqZAac3TK23thPO4ja6ictZsx wDw8w3DorqXAvc80B8M+mwEWGvd1RS7bfThu58QJOkBsfIpBqms5/iMGDCaukx5kt0RS 6Y5uw3shEJ2bDkQNInSUYGaTICc2Uxyz/GKnIgKIxyr6LFELmhv9MYl0S9lR0lBA0ODH mfxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=iFXU6KuBfcve29crjXH2P8kwZ0XtTWD3YQGvFnfJ1fg=; b=mV5bw/Zf0YlYXzsiyMem/790Sj3PrISpbn9TcGGY9Nsz4zXq5EkiJJIa7+e36tLkLk VNBu4MrjEtunICpLDSt5NMB5i+a4Hzd75ZUtO5jHFzz8Se0QJXn4iblLBmQjJfMn6vBo Ft3Z/s23aBel6PWobTR7r3QIFBcHNI0ElRa83ADLE7OdZMpNxllny90PGwcIkhZwDHWR 0CGR/1bYcFBP/brAyisep9ECHUug5LqMgWpq/9o498vCd8MySq1Dy25hyrS8IuE21yUW T6NhvBo/6UBRBS5LNQ0Xe/LbBSukQu3ws4hVtUAXTTyUZHRmxyeWJ4Z6aj68V5Oxoehn av5Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Jh8jzQ4m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h3-v6si48260045pfd.228.2018.11.06.01.19.56; Tue, 06 Nov 2018 01:20:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Jh8jzQ4m; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730094AbeKFSnn (ORCPT + 99 others); Tue, 6 Nov 2018 13:43:43 -0500 Received: from mail-oi1-f194.google.com ([209.85.167.194]:43179 "EHLO mail-oi1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729160AbeKFSnn (ORCPT ); Tue, 6 Nov 2018 13:43:43 -0500 Received: by mail-oi1-f194.google.com with SMTP id j202-v6so10091514oih.10 for ; Tue, 06 Nov 2018 01:19:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iFXU6KuBfcve29crjXH2P8kwZ0XtTWD3YQGvFnfJ1fg=; b=Jh8jzQ4mWv05gOzhjxAKlgIc/E+Py9lrlljjUq966J6ZgrQGOaYD7z3na2kmUmtIbl FICMQ+eYhdXYuo1vEDglKU4iOIUHhqPgPMTqlDAlov0/wr+urI2r/WEMjWfHykZQWXzm 39Lsmeb5yHfMdotHRxD3uYnbbofHOqm2l1WpE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iFXU6KuBfcve29crjXH2P8kwZ0XtTWD3YQGvFnfJ1fg=; b=ldEFkSkXSWmxxXaEQsB3UEWIzGACAeEk2CmYxaQ7RyYBBNsyVVr9Ahd+ghs+/WdcTR fw6rI0AkB8xFXGM6quUwh8QpHjteTiSncM6rMC9cHvvDCIUcnuKpLXXdhyJQ/IkzRtCE APBKOEIEzvaXS+guLSZ3fP43VTCDOMAh/FQxbmelvp6ISFFsZYmca11DIPDG7y4aWwTu 1PZ7jjImxIZb/ycegbrHXE9v7rmrJGR0YZnMMBh7ReOyqT+ltiUgJ5cA+XCQ7tH1TQox i55iS20WNFSZ0+dl/xNlufXkP+wXhrX8j8lPOSLzFB8oxS8Hin6xdsaXRtGxF2pLxr1O IS8g== X-Gm-Message-State: AGRZ1gKmng/dr20d7YwcF1m5h0eyhj0Iq1oCl+2B00TSwdt+70cQ0zEa PrEnBN/Zls73eZEbBLiEBhJK/1xHhmFdk+lWvLpNjiw= X-Received: by 2002:aca:5f45:: with SMTP id t66-v6mr2293352oib.20.1541495966330; Tue, 06 Nov 2018 01:19:26 -0800 (PST) MIME-Version: 1.0 References: <20181106090352.64114-1-vovoy@chromium.org> <20181106090839.GE27423@dhcp22.suse.cz> In-Reply-To: <20181106090839.GE27423@dhcp22.suse.cz> From: Kuo-Hsin Yang Date: Tue, 6 Nov 2018 17:19:15 +0800 Message-ID: Subject: Re: [PATCH v5] mm, drm/i915: mark pinned shmemfs pages as unevictable To: mhocko@kernel.org Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, Chris Wilson , Joonas Lahtinen , Peter Zijlstra , Andrew Morton , Dave Hansen Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 6, 2018 at 5:08 PM Michal Hocko wrote: > > On Tue 06-11-18 17:03:51, Kuo-Hsin Yang wrote: > > The i915 driver uses shmemfs to allocate backing storage for gem > > objects. These shmemfs pages can be pinned (increased ref count) by > > shmem_read_mapping_page_gfp(). When a lot of pages are pinned, vmscan > > wastes a lot of time scanning these pinned pages. In some extreme case, > > all pages in the inactive anon lru are pinned, and only the inactive > > anon lru is scanned due to inactive_ratio, the system cannot swap and > > invokes the oom-killer. Mark these pinned pages as unevictable to speed > > up vmscan. > > > > Export pagevec API check_move_unevictable_pages(). > > > > This patch was inspired by Chris Wilson's change [1]. > > > > [1]: https://patchwork.kernel.org/patch/9768741/ > > > > Cc: Chris Wilson > > Cc: Joonas Lahtinen > > Cc: Peter Zijlstra > > Cc: Andrew Morton > > Cc: Dave Hansen > > Signed-off-by: Kuo-Hsin Yang > > Acked-by: Michal Hocko > > please make it explicit that the ack applies to mm part as i've > mentioned when giving my ack to the previous version. > > E.g. > Acked-by: Michal Hocko # mm part > > because i am not familiar with the drm code to ack any changes there. Got it. Thanks.