Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] fuse: Put leaked request on error path of fuse_retrieve()
To:     Miklos Szeredi <miklos@szeredi.hu>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
References: <154149557692.17196.12607896696117775780.stgit@localhost.localdomain>
 <CAJfpegtMmrvnZE3xtMDNTmF=pSmqFROtehamivbLeAh2E_qZ6Q@mail.gmail.com>
 <b3162ccb-f6d8-b0d4-5cfe-313e89c49a1d@virtuozzo.com>
 <CAJfpegs+kbFqChz0wKEW+nDBH=M+S+UsDW1w7hyvj3yLmHnuWw@mail.gmail.com>
From:   Kirill Tkhai <ktkhai@virtuozzo.com>
Message-ID: <5e2fa16d-1408-4c34-1f9d-a6ccfe345358@virtuozzo.com>
Date:   Tue, 6 Nov 2018 12:34:23 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <CAJfpegs+kbFqChz0wKEW+nDBH=M+S+UsDW1w7hyvj3yLmHnuWw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 06.11.2018 12:33, Miklos Szeredi wrote:
> On Tue, Nov 6, 2018 at 10:25 AM, Kirill Tkhai <ktkhai@virtuozzo.com> wrote:
>> On 06.11.2018 12:23, Miklos Szeredi wrote:
>>> On Tue, Nov 6, 2018 at 10:13 AM, Kirill Tkhai <ktkhai@virtuozzo.com> wrote:
>>>> fuse_request_send_notify_reply() may fail, and this case
>>>> it remains leaked (fuse_retrieve_end(), which is called
>>>> on error path, does not do that). Also, fc->num_waiting,
>>>> will never be decremented, and fuse_wait_aborted() will
>>>> never finish. So, put the request patently.
>>>>
>>>> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
>>>
>>> Posted same patch yesterday for a syzbot report.   How did you notice this?
>>
>> I've found this by code review. I did this last week and I have 10 patches more
>> on different theme. I was waiting for when the merge window opens.
> 
> Well, the merge window just closed.  But never worry, bugfixes can go
> in at anytime.
> 
> If you notice a bug, such as this, you don't need to hold back until
> any particular time, the sooner it's known, the better.

Ok, no problem :)

Thanks,
Kirill