Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1763727imu; Tue, 6 Nov 2018 04:04:56 -0800 (PST) X-Google-Smtp-Source: AJdET5c2mmH2DPwv/05DNPczRZ+ByyLpz7Jmk4x0qSzJrcxmtlF9rWt1i9YCgPWvOVUa+QNoXeH1 X-Received: by 2002:a63:5c61:: with SMTP id n33-v6mr22561153pgm.1.1541505896588; Tue, 06 Nov 2018 04:04:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541505896; cv=none; d=google.com; s=arc-20160816; b=juUgpQo1L2+euLgRm40FwC9zL3MVAkTvQbreP7pjKJq7EdzVfhquZki7wqN+1j85C0 j17PrkI01XkGUmFnG7E6o2rSy9ZznoVMTmUGKaycBHWtD2tunX6DoShTtGnG86Y0013p W/k7+Xw0VOSlqfjpw1fgxCEHLmSGzxXeDSHb0IbmhZ59w7au3ctNIb+3O5D7Qd4GECUY 4KZGtTeuGEbOBeh6bKLqIl8z32Ngp4hhmpMxR0BNJ7bcKC92qGXg1Xo6MMp5IIMEVqFs oxu/W2HsCYbMUFmoPVEiJIKAnNmiH2+cJseU9CMlMC7RdFJY0HXRtwJzp0Bze+O+Q6t7 tKPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=xEoUoTAIOdW8rPt66FqC+zBnmS5BPZAjijOe5gWsEBo=; b=fTBlFlLzrqQvQAj1Qcp2e5sHCu3XX0I6x5okCYQLBD2Vl6q1x736f3KUpB4jZJBpHW +E11aVEwJkRhihRP94OYuALsIiKRmrHhOQ3Ic3iQUKv6BatdGeyZ+L9f5MlCCBOGU1fM CDqNmzfvPpcAMolLa1Vt6k+qWFkpccsS40Nkr5CEdgjARSIg0ojKuaDniP+76bc3VfoG g/eJEO8T8E2VCuJCe5R9AaICq3gfpXfo+REULY7Hhmmhd62dGK+o0iBpYib1LkRT3bxE qKKP6aHA8tsgbVkhMAqP20Cf5CDouw5d3kezHRBcdCjgI1f4SmudvzYYaPSXHAlGuYuq 2B0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d69si7014869pga.184.2018.11.06.04.04.36; Tue, 06 Nov 2018 04:04:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387532AbeKFV2o (ORCPT + 99 others); Tue, 6 Nov 2018 16:28:44 -0500 Received: from mga05.intel.com ([192.55.52.43]:37789 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726976AbeKFV2o (ORCPT ); Tue, 6 Nov 2018 16:28:44 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2018 04:03:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,471,1534834800"; d="scan'208";a="278729922" Received: from btyborox-mobl.ger.corp.intel.com (HELO localhost) ([10.249.254.134]) by fmsmga006.fm.intel.com with ESMTP; 06 Nov 2018 04:03:42 -0800 Date: Tue, 6 Nov 2018 14:03:41 +0200 From: Jarkko Sakkinen To: Andy Shevchenko Cc: "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Platform Driver , linux-sgx@vger.kernel.org, Dave Hansen , sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, serge.ayoun@intel.com, shay.katz-zamir@intel.com, haitao.huang@intel.com, mark.shanahan@intel.com, Andy Shevchenko , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , suresh.b.siddha@intel.com, Linux Kernel Mailing List Subject: Re: [PATCH v15 15/23] x86/sgx: Add wrappers for ENCLS leaf functions Message-ID: <20181106120341.GA11465@linux.intel.com> References: <20181102231320.29164-1-jarkko.sakkinen@linux.intel.com> <20181102231320.29164-16-jarkko.sakkinen@linux.intel.com> <20181105173038.GD4502@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 05, 2018 at 10:39:46PM +0200, Andy Shevchenko wrote: > On Mon, Nov 5, 2018 at 7:30 PM Jarkko Sakkinen > wrote: > > > > On Sat, Nov 03, 2018 at 03:17:35PM +0200, Andy Shevchenko wrote: > > > On Sat, Nov 3, 2018 at 1:18 AM Jarkko Sakkinen > > > wrote: > > > > > > > > ENCLS is an umbrella instruction for a variety of cpl0 SGX functions. > > > > The ENCLS function that is executed is specified in EAX, with each > > > > function potentially having more leaf-specific operands beyond EAX. > > > > ENCLS introduces its own (positive value) error codes that (some) > > > > leafs use to return failure information in EAX. Leafs that return > > > > an error code also modify RFLAGS. And finally, ENCLS generates > > > > ENCLS-specific non-fatal #GPs and #PFs, i.e. a bug-free kernel may > > > > encounter faults on ENCLS that must be handled gracefully. > > > > > > > > Because of the complexity involved in encoding ENCLS and handling its > > > > assortment of failure paths, executing any given leaf is not a simple > > > > matter of emitting ENCLS. > > > > > > > > To enable adding support for ENCLS leafs with minimal fuss, add a > > > > two-layer macro system along with an encoding scheme to allow wrappers > > > > to return trap numbers along ENCLS-specific error codes. The bottom > > > > layer of the macro system splits between the leafs that return an > > > > error code and those that do not. The second layer generates the > > > > correct input/output annotations based on the number of operands for > > > > each leaf function. > > > > > > > +/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */ > > > > > > > +/** > > > > > > I dunno if kernel-doc script still complains about this. > > > > Is there a way to ask for make htmldocs to do only a subset of docs? > > Still kind of trying to figure out what would be a good flow for > > working with Sphinx. > > What I'm telling here is about Copyright notice, which in my > understanding is not a part of kernel-doc formatting. Though I might > be mistaken. > I remember some USB code has that and I saw a warning. > > -- > With Best Regards, > Andy Shevchenko I'll remove it because I don't find it in other headers under arch/x86. /Jarkko