Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181106134630.29591-1-smuchun@gmail.com> <CAJZ5v0ifsQqkoFw2tossFKJAUkqDLdR9NpN3eZTn3t0xUz6K-g@mail.gmail.com>
In-Reply-To: <CAJZ5v0ifsQqkoFw2tossFKJAUkqDLdR9NpN3eZTn3t0xUz6K-g@mail.gmail.com>
From:   Muchun Song <smuchun@gmail.com>
Date:   Tue, 6 Nov 2018 22:43:39 +0800
Message-ID: <CAPSr9jE8EbWue31LP18eF9+KysZHNRqHNrzif8H4NkCzHHtueQ@mail.gmail.com>
Subject: Re: [PATCH] driver core: Add branch prediction hints in really_probe()
To:     rafael@kernel.org
Cc:     gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Rafael,

If we want the driver core to test driver remove functions, we can
enable CONFIG_DEBUG_TEST_DRIVER_REMOVE. This option is
just for testing it. So, in most cases, the option is disabled and the if
condition is false. So I think we can add an unlikely() to it.

Rafael J. Wysocki <rafael@kernel.org> =E4=BA=8E2018=E5=B9=B411=E6=9C=886=E6=
=97=A5=E5=91=A8=E4=BA=8C =E4=B8=8B=E5=8D=8810:30=E5=86=99=E9=81=93=EF=BC=9A
>
> On Tue, Nov 6, 2018 at 2:47 PM Muchun Song <smuchun@gmail.com> wrote:
> >
> > If condition is false in most cases. So, add an unlikely() to the if
> > condition, so that the optimizer assumes that the condition is false.
> >
> > Signed-off-by: Muchun Song <smuchun@gmail.com>
>
> Have you measured the practical impact of this patch in any way?
>
> > ---
> >  drivers/base/dd.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/base/dd.c b/drivers/base/dd.c
> > index 169412ee4ae8..8eba453c4e5d 100644
> > --- a/drivers/base/dd.c
> > +++ b/drivers/base/dd.c
> > @@ -450,7 +450,7 @@ static int really_probe(struct device *dev, struct =
device_driver *drv)
> >         bool test_remove =3D IS_ENABLED(CONFIG_DEBUG_TEST_DRIVER_REMOVE=
) &&
> >                            !drv->suppress_bind_attrs;
> >
> > -       if (defer_all_probes) {
> > +       if (unlikely(defer_all_probes)) {
> >                 /*
> >                  * Value of defer_all_probes can be set only by
> >                  * device_defer_all_probes_enable() which, in turn, wil=
l call
> > @@ -508,7 +508,7 @@ static int really_probe(struct device *dev, struct =
device_driver *drv)
> >                         goto probe_failed;
> >         }
> >
> > -       if (test_remove) {
> > +       if (unlikely(test_remove)) {
> >                 test_remove =3D false;
> >
> >                 if (dev->bus->remove)
> > --
> > 2.17.1
> >