Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2040685imu; Tue, 6 Nov 2018 08:11:28 -0800 (PST) X-Google-Smtp-Source: AJdET5cx4/4zHtlcSnlrFNa69OWKfsriNZx4r6n4tu7QilwFRCeBVIRE4jpuMGY3zQ8oeDdxBscH X-Received: by 2002:a17:902:ab83:: with SMTP id f3-v6mr21755936plr.122.1541520688054; Tue, 06 Nov 2018 08:11:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541520688; cv=none; d=google.com; s=arc-20160816; b=ZqOyLVBOr2zgbAN+78Wc6AGmjGgXFdPAdsr7O+PAAtQUbKe9H/37UxepogTYrWIy/f S6c34UK9mDUX9KItDQZDXLkf1g11olsFOeehJBFNm4SmrGH2ClpRlxYcOSLHz91xwKKP sO3dbDwrt0FWcVxbv2UhjHVHiLPTIOUR/NPhKv6kUsv6/byXGLddRHZKyAvwQtfwjAJ7 ucoasWwvUZvg+HS1+S3t5ymJ9OOKMbPwEgAFLLD0QGESHga0noFIBqfbrEQcGzMNybaq BcwZjbZirpkcxp1ic9kwcBoDEGlHHjiVwaYZO4T8xmcKhjdUi9DjMycyQaWTQFw9J4lX QjFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:in-reply-to :subject:cc:to:from:date; bh=KGPrLdXF9DB6sC0vxPFd8vge3+EeoJMrOQXxxvp2iao=; b=SP6dge6bO4HjyJ6tsTAyWR5t8eC8tjmYYwn+OTKRmKLMEwPKcBMDX8wPFdVSaodPt6 4Xeyto64ge4XoeXGW82CEvwCG/QBpGBkzhzm3KuxCOROHNjRi5DGBMvvEgXq70l5339e 43SwaTpd6AoNh3cuZdOV/REcx+8cM14ypLInBKqauBAGWO9MUKrGj/FGt11sqw3zGngZ CZtuRD6l9xUxjq2AlYHGpz3RYXaxA6bzFs0dk7UprYkDF78KwoxeCPCuM3sMmFy9nF2n qSrzwq34QLA569WCcmKqUB9IMOEKa+W2WdFTsi9NPkkGWf8suGIDmtDWiw8ZruJfwoBH 5+4g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o1-v6si3561615pld.229.2018.11.06.08.11.07; Tue, 06 Nov 2018 08:11:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389169AbeKGBeq (ORCPT + 99 others); Tue, 6 Nov 2018 20:34:46 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:37098 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S2388346AbeKGBeq (ORCPT ); Tue, 6 Nov 2018 20:34:46 -0500 Received: (qmail 4612 invoked by uid 2102); 6 Nov 2018 11:08:52 -0500 Received: from localhost (sendmail-bs@127.0.0.1) by localhost with SMTP; 6 Nov 2018 11:08:52 -0500 Date: Tue, 6 Nov 2018 11:08:52 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Al Cooper cc: linux-kernel@vger.kernel.org, Alban Bedel , Alex Elder , Andrew Morton , Arnd Bergmann , Avi Fishman , , Bjorn Andersson , Chunfeng Yun , "David S. Miller" , , Dmitry Osipenko , Greg Kroah-Hartman , "Gustavo A. R. Silva" , Hans de Goede , James Hogan , Jianguo Sun , Johan Hovold , Kees Cook , , Lu Baolu , Mark Rutland , Martin Blumenstingl , Mathias Nyman , Mathias Nyman , Mauro Carvalho Chehab , Rishabh Bhatnagar , Rob Herring , Roger Quadros Subject: Re: [PATCH V3 4/6] usb: ohci-platform: Add support for Broadcom STB SoC's In-Reply-To: <1541453493-34981-5-git-send-email-alcooperx@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 5 Nov 2018, Al Cooper wrote: > Add support for Broadcom STB SoC's to the ohci platform driver. > > Signed-off-by: Al Cooper > --- > @@ -177,6 +189,8 @@ static int ohci_platform_probe(struct platform_device *dev) > ohci->flags |= OHCI_QUIRK_FRAME_NO; > if (pdata->num_ports) > ohci->num_ports = pdata->num_ports; > + if (pdata->suspend_without_phy_exit) > + hcd->suspend_without_phy_exit = 1; Sorry if I missed this in the earlier discussions... Is there any possibility of adding a DT binding that could express this requirement, instead of putting it in the platform data? Alan Stern