Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 94956601D7
Subject: Re: [PATCH V3 2/2] mmc: sdhci-msm: Re-initialize DLL if MCLK is gated
 dynamically
To:     Doug Anderson <dianders@google.com>
Cc:     Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Evan Green <evgreen@chromium.org>,
        Asutosh Das <asutoshd@codeaurora.org>, riteshh@codeaurora.org,
        stummala@codeaurora.org, sayalil@codeaurora.org,
        LKML <linux-kernel@vger.kernel.org>
References: <1541073999-11752-1-git-send-email-vbadigan@codeaurora.org>
 <1541073999-11752-3-git-send-email-vbadigan@codeaurora.org>
 <CAD=FV=U7FGn0Jt_63SJ0zeU9u4vh5J9EFtbLHGtjGOUV7AceKw@mail.gmail.com>
From:   Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
Message-ID: <ed0de1bd-d2f5-a1e6-9799-52f3a6ad91f4@codeaurora.org>
Date:   Tue, 6 Nov 2018 23:21:14 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <CAD=FV=U7FGn0Jt_63SJ0zeU9u4vh5J9EFtbLHGtjGOUV7AceKw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 11/2/2018 2:03 AM, Doug Anderson wrote:
> Hi,
>
> On Thu, Nov 1, 2018 at 5:08 AM Veerabhadrarao Badiganti
> <vbadigan@codeaurora.org> wrote:
>>   static const struct sdhci_msm_variant_info sdhci_msm_v5_var = {
>>          .mci_removed = true,
>> +       .restore_dll_config = false,
>> +       .var_ops = &v5_var_ops,
>> +       .offset = &sdhci_msm_v5_offset,
>> +};
>> +
>> +static const struct sdhci_msm_variant_info sdm845_sdhci_var = {
>> +       .mci_removed = true,
>> +       .restore_dll_config = true,
>>          .var_ops = &v5_var_ops,
>>          .offset = &sdhci_msm_v5_offset,
>>   };
> One last thing: are there actually any "v5" controllers that _don't_
> require restoring the DLL?  Since "sdm845" is currently the only v5
> controller maybe just set "restore_dll_config = true" for all v5
> controllers and when there's a new v5 controller that doesn't need it
> then match off the SoC-specific compatible string.  As per my review
> of the bindings patch IMO you should include both the "v5" and the
> SoC-specific string for SDM845 (and all future SoCs) so you could make
> the generic v5 case do this...
>

Yes. QCS404 is one of the target which uses "V5" controller and it 
doesn't need restoring of DLL.
I checked your comments on bindings patch. Will update it in the next 
patchset.

> -Doug

Thanks,
Veera